Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot Prometheus disk after tearing Prometheus down #1199

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Snapshot Prometheus disk after tearing Prometheus down #1199

merged 1 commit into from
Apr 30, 2020

Conversation

jkaniuk
Copy link
Contributor

@jkaniuk jkaniuk commented Apr 29, 2020 •
edited
Loading

Gracefully tear down Prometheus retaining PD, then snapshot and delete PD.

Fix: #1020

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2020
@k8s-ci-robot
Copy link
Contributor

@jkaniuk: GitHub didn't allow me to request PR reviews from the following users: jkaniuk.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc jkaniuk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2020
@jkaniuk jkaniuk force-pushed the snapshot-after-teardown branch 4 times, most recently from 83c0cb2 to fe027d5 Compare April 29, 2020 23:13
@jkaniuk jkaniuk changed the title [WIP] Snapshot Prometheus disk after tearing Prometheus down Snapshot Prometheus disk after tearing Prometheus down Apr 30, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2020
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Apr 30, 2020

/cc mm4tt oxddr

oxddr
oxddr reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@oxddr oxddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single nit, other than that LG.

clusterloader2/pkg/prometheus/experimental.go Outdated Show resolved Hide resolved
@oxddr
Copy link
Contributor

oxddr commented Apr 30, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkaniuk, oxddr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit d25aba2 into kubernetes:master Apr 30, 2020
This was referenced May 5, 2020
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxddr oxddr oxddr left review comments

@mm4tt mm4tt Awaiting requested review from mm4tt

Assignees

@oxddr oxddr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ClusterLoader2] Prometheus metrics corrupted
3 participants
@jkaniuk @k8s-ci-robot @oxddr