Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase page size in slo-monitor to 5000 (attempt #2). #1449

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

mborsz
Copy link
Member

@mborsz mborsz commented Sep 2, 2020

The previous attempt to increase page size was incorrect (was changing a pagination that is noop).

It seems to work now:

I0902 09:54:33.023988       1 httplog.go:90] verb="GET" URI="/api/v1/pods?limit=5000&resourceVersion=0" latency=3.396776ms resp=200 UserAgent="slo-monitor/v0.0.0 (linux/amd64) kubernetes/$Format" srcIP="[::1]:49440":
I0902 09:54:34.031390       1 httplog.go:90] verb="GET" URI="/api/v1/events?fieldSelector=involvedObject.kind%3DPod%2Csource%3Dkubelet&limit=5000&resourceVersion=0" latency=34.948446ms resp=200 UserAgent="slo-monitor/v0.0.0 (linux/amd64) kubernetes/$Format" srcIP="[::1]:49440":

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Sep 2, 2020

Great - thanks Maciek!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5da4e75 into kubernetes:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants