Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin python and pip to v2 version #1457

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Sep 7, 2020

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 7, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2020
@mm4tt mm4tt force-pushed the numpy_fix branch 3 times, most recently from 8355a76 to 6894a20 Compare September 7, 2020 10:04
@mm4tt mm4tt changed the title WIP - specify numpy version WIP - pin python and pip to v2 version Sep 7, 2020
@mm4tt mm4tt changed the title WIP - pin python and pip to v2 version Pin python and pip to v2 version Sep 7, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2020
Otherwise, in the newer kubekins versions pip points to pip3 while python points to python2. It results in setup errors and test failures

Fixes kubernetes/kubernetes#94473
@mm4tt
Copy link
Contributor Author

mm4tt commented Sep 7, 2020

/assign @jkaniuk

@mm4tt
Copy link
Contributor Author

mm4tt commented Sep 7, 2020

/assign @jprzychodzen

@jprzychodzen
Copy link
Contributor

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jprzychodzen, mm4tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 38c4e0c into kubernetes:master Sep 7, 2020
@jkaniuk
Copy link
Contributor

jkaniuk commented Sep 7, 2020

Python2 is deprecated. Could you update to Python 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test] ci-benchmark-kube-dns-master
4 participants