-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Golang job script printing Golang repo commit hash #1556
Conversation
5fe8a09
to
c358702
Compare
/assign @mm4tt |
local -r go_version=$(go version $GOPATH/src/k8s.io/perf-tests/kubernetes/client/bin/kubectl) | ||
local -r go_commit_hash=$(echo -n $go_version | awk '{ print $3 }' | cut -c2-) | ||
local -r dashline=$(printf %100s | tr " " "-") | ||
echo "${dashline}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also print the go_version? It wouldn't hurt, but will save us time if in the future the go version format changes and go_commit_hash will become gibberish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Done.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, tosi3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Small facilitation utility for debugging Golang-related regressions.
/sig scalability