-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace references to old topology labels with the new ones #1563
Replace references to old topology labels with the new ones #1563
Conversation
/lgtm thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tosi3k, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -86,7 +86,7 @@ func (pc *Controller) tryRetrievePrometheusDiskMetadata() (bool, error) { | |||
} | |||
klog.V(2).Infof("Found Prometheus' PV with name: %s", pv.Name) | |||
pdName = pv.Spec.GCEPersistentDisk.PDName | |||
zone = pv.ObjectMeta.Labels["failure-domain.beta.kubernetes.io/zone"] | |||
zone = pv.ObjectMeta.Labels["topology.kubernetes.io/zone"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason prometheus' disk is still using failure-domain.beta.kubernetes.io.zone: kubernetes/kubernetes#96509 (comment)
First reported here https://github.com/orgs/kubernetes/projects/11#card-49104618 |
Before the next attempt to submit this we should make sure that presubmit used by perf-test repo uses --check-leaked-resources (and potential other differences between ci-kubernetes-e2e-gci-gce-scalability and perf-tests and k/k presubmits). This would block submission of this PR. |
Output of grepping
failure-domain.beta.kubernetes.io
at the top-level perf-tests repo directory,master
branch:Not seeing any references to
LabelZoneFailureDomain
norLabelZoneRegion
in the non-vendored code.Fixes #1554.
/sig scalability
/assign @mm4tt @wojtek-t