Fix dns benchmark failing after python 2->3 migration #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
mm4tt
force-pushed
the
dns_python3
branch
3 times, most recently
from
de4a58f
to
39600c4
Compare
k8s-ci-robot
added
size/S
mm4tt
force-pushed
the
dns_python3
branch
5 times, most recently
from
f20ad7b
to
bfb8ddf
Compare
mm4tt
commented
Nov 23, 2020
| @@ -161,8 +162,6 @@ def _kubectl(self, stdin, *args): | |||
| """ | |||
| cmdline = [self.args.kubectl_exec] + list(args) | |||
| _log.debug('kubectl %s', cmdline) | |||
| if stdin: | |||
| _log.debug('kubectl stdin\n%s', add_prefix('in | ', stdin)) | |||
There was a problem hiding this comment.
I removed this logging as it was causing more harm than good. We're logging stdin here, which can be anything, e.g. a tar archive...
|
/assign @prameshj |
|
/lgtm It seems the tests are passing now, which is great. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel Thanks Matt! |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, prameshj, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #1586