Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing bash options to dns/run.sh #1588

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Nov 20, 2020

This is, among others, to properly propagate error status.

Ref. #1586

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2020
This is, among others, to properly propagate error status.

Ref. kubernetes#1586
@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

@mm4tt: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-perf-tests-benchmark-kube-dns 6312eb9 link /test pull-perf-tests-benchmark-kube-dns

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mm4tt
Copy link
Contributor Author

mm4tt commented Nov 20, 2020

The pull-perf-tests-benchmark-kube-dns test failed, but it's exactly what we wanted to achieve. We'll fix it later.
It's not a required presubmit so it won't block merging.

@prameshj
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, prameshj, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mm4tt
Copy link
Contributor Author

mm4tt commented Nov 23, 2020

Looks like the pull-perf-tests-benchmark-kube-dns is not optional :/

I could make it optional then merge this and then make it back required. However, I'm not sure if it's worth the hassle. Let me try merging this PR with the test failing.

@mm4tt mm4tt merged commit 36e8f4f into kubernetes:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants