Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prometheus operator and prometheus #1763

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

s-urbaniak
Copy link
Contributor

@s-urbaniak s-urbaniak commented Mar 12, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This bumps prometheus-operator to its newest version v0.46.0 and is a simplified version of #1661

Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 12, 2021
@wojtek-t
Copy link
Member

@s-urbaniak - the failure are related to this change (prometheus stack not starting correctly).
Can you please take a look?

@mborsz
Copy link
Member

mborsz commented Mar 17, 2021

/retest

@s-urbaniak
Copy link
Contributor Author

@mborsz @wojtek-t can you PTAL?

@mborsz
Copy link
Member

mborsz commented Mar 23, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 81c96c3 into kubernetes:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants