Implement watch-based daemonset replica counter. #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
mborsz
force-pushed
the
da
branch
4 times, most recently
from
f8bd996
to
9b3a7c4
Compare
wojtek-t
reviewed
Apr 7, 2021
clusterloader2/pkg/measurement/util/runtimeobjects/replicaswatcher.go
Outdated
Show resolved
Hide resolved
|
|
||
| // ConstReplicas is a ReplicasWatcher implementation that returns a constant value. | ||
| type ConstReplicas struct { | ||
| Const int |
There was a problem hiding this comment.
I think "Replicas int" would be more intuitive :)
There was a problem hiding this comment.
I tried that initially, but I got "field and method with the same name Replicas (see details)" compiler error :)
There was a problem hiding this comment.
Maybe ReplicasCount ?
Const is too ambiguous to me.
clusterloader2/pkg/measurement/util/runtimeobjects/replicaswatcher.go
Outdated
Show resolved
Hide resolved
clusterloader2/pkg/measurement/util/runtimeobjects/runtimeobjects_test.go
Show resolved
Hide resolved
mborsz
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
This is ready for review. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: waitForControlledPodsRunning for daemonsets calculates a number of expected replicas based on the number of nodes that are schedule. That number can vary over time (e.g. node becoming notready/ready).
We are seeing a tests runs where e.g. node X was unhealthy for a short period of time for whatever reason (physical machine failure). During that time, we calculated a number of replicas. Then node becomes healthy and daemonset controller creates more replicas than we expect making the test fail.
This code introduces a watch for node objects to track accurate number of expected replicas over time