Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NewInformer to cache.ListerWatcher #1780

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

mborsz
Copy link
Member

@mborsz mborsz commented Apr 7, 2021

Migrate informer.NewInformer to cache.ListerWatcher to:

  • provide compile-time validation of resources (e.g. typo in resource name will be detected in compilation time)
  • make it testable:
    • previous code uses on RESTClient which isn't implemented by kubernetes' fake.NewSimpleClientset()
    • this code uses a standard way of creating informers which is properly handled by fake.NewSimpleClientset()

I still let informer.NewInformer exists as it has convenient addEventHandler call.

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@wojtek-t
Copy link
Member

wojtek-t commented Apr 7, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mborsz
Copy link
Member Author

mborsz commented Apr 7, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit fa899dc into kubernetes:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants