add ENABLE_IN_CLUSTER_NETWORK_LATENCY and RUN_ON_ARM_NODES variables for arm testing #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
amacaskill
force-pushed
the
disable-incluster-network-latency
branch
from
cf09f94
to
10a1ab8
Compare
amacaskill
force-pushed
the
disable-incluster-network-latency
branch
from
10a1ab8
to
9d99ae5
Compare
k8s-ci-robot
added
needs-rebase
amacaskill
force-pushed
the
disable-incluster-network-latency
branch
2 times, most recently
from
4306e75
to
72c55e2
Compare
k8s-ci-robot
added
size/M
amacaskill
force-pushed
the
disable-incluster-network-latency
branch
from
83739b8
to
976b34a
Compare
k8s-ci-robot
added
the
needs-rebase
amacaskill
force-pushed
the
disable-incluster-network-latency
branch
4 times, most recently
from
4451e65
to
edcc744
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm /assign @marseel |
k8s-ci-robot
added
the
lgtm
|
Actually, I see that you are missing simple-deployment.yaml. Could you add it? Nit: This PR does a little more, please change PR/commit description. /lgtm cancel |
k8s-ci-robot
removed
the
lgtm
amacaskill
force-pushed
the
disable-incluster-network-latency
branch
from
3e8b183
to
80831e8
Compare
amacaskill
force-pushed
the
disable-incluster-network-latency
branch
from
80831e8
to
f7c1fd7
Compare
amacaskill
changed the title
amacaskill
changed the title
amacaskill
changed the title
Updated the title and description |
|
/lgtm /cc @marseel Could you review? |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, jprzychodzen, marseel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the ENABLE_IN_CLUSTER_NETWORK_LATENCY and RUN_ON_ARM_NODES environment variables which are necessary to run the load test on arm64 nodes.
ENABLE_IN_CLUSTER_NETWORK_LATENCY is needed to disable InClusterNetworkLatency because it doesn't work on arm. RUN_ON_ARM_NODES is needed to set the kubernetes.io/arch:arm64 NoSchedule pod toleration in the deployment, simple-deployment, statefulset, daemonset, and job yaml files in the load test module. Nodepools created in 1.24 have a taint to not schedule on arm64 architectures, so the toleration is needed for the pods to be able to schedule to arm64 nodes.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: