-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ENABLE_IN_CLUSTER_NETWORK_LATENCY and RUN_ON_ARM_NODES variables for arm testing #2086
add ENABLE_IN_CLUSTER_NETWORK_LATENCY and RUN_ON_ARM_NODES variables for arm testing #2086
Conversation
cf09f94
to
10a1ab8
Compare
10a1ab8
to
9d99ae5
Compare
4306e75
to
72c55e2
Compare
83739b8
to
976b34a
Compare
4451e65
to
edcc744
Compare
/lgtm /assign @marseel |
Actually, I see that you are missing simple-deployment.yaml. Could you add it? Nit: This PR does a little more, please change PR/commit description. /lgtm cancel |
3e8b183
to
80831e8
Compare
80831e8
to
f7c1fd7
Compare
Updated the title and description |
/lgtm /cc @marseel Could you review? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, jprzychodzen, marseel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the ENABLE_IN_CLUSTER_NETWORK_LATENCY and RUN_ON_ARM_NODES environment variables which are necessary to run the load test on arm64 nodes.
ENABLE_IN_CLUSTER_NETWORK_LATENCY is needed to disable InClusterNetworkLatency because it doesn't work on arm. RUN_ON_ARM_NODES is needed to set the kubernetes.io/arch:arm64 NoSchedule pod toleration in the deployment, simple-deployment, statefulset, daemonset, and job yaml files in the load test module. Nodepools created in 1.24 have a taint to not schedule on arm64 architectures, so the toleration is needed for the pods to be able to schedule to arm64 nodes.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: