Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Windows metrics in perfdash #2088

Merged

Conversation

oprinmarius
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:
Collect Windows metrics from Soak test jobs and expose them in perfdash

Which issue(s) this PR fixes:

part of kubernetes/kubernetes#108621
depends on #2034

Special notes for your reviewer:
Collect Windows metrics and expose them in perfdash

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2022
@oprinmarius
Copy link
Member Author

/assign @mborsz

@mborsz
Copy link
Member

mborsz commented Jun 24, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, oprinmarius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit f632d66 into kubernetes:master Jun 24, 2022
@oprinmarius
Copy link
Member Author

/test post-k8sio-deploy-app-perfdash

@oprinmarius oprinmarius deleted the feat/perfdash-windows-metrics branch June 28, 2022 09:48
@mborsz
Copy link
Member

mborsz commented Jun 30, 2022

I just deployed new version of perfdash to http://perf-dash.k8s.io/. It will likely require few hours to initialize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants