-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sleep after deleting LBs in l4lb test #2107
Conversation
cdbbaa8
to
8b22fb5
Compare
/assign marseel |
@@ -87,6 +90,12 @@ steps: | |||
objectTemplatePath: service.yaml | |||
- basename: lb-dep | |||
objectTemplatePath: dep.yaml | |||
- name: Sleep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, right now we can have sleep, but in the future we would like to have something like "WaitForServices" so we don't need to have this sleep.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marseel, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Add sleep to wait for LB resources to be cleaned up, before deleting
In the current state, cluster gets deleted, and 10 minutes (default wait to clean up resources) is not enough to remove all LBs and Deployments, that is why tests are failing