Add sleep after deleting LBs in l4lb test #2107
Merged
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
panslava
changed the title
panslava
force-pushed
the
fix-ilb-tests
branch
2 times, most recently
from
cdbbaa8
to
8b22fb5
Compare
|
/assign marseel |
marseel
reviewed
Aug 1, 2022
| @@ -87,6 +90,12 @@ steps: | |||
| objectTemplatePath: service.yaml | |||
| - basename: lb-dep | |||
| objectTemplatePath: dep.yaml | |||
| - name: Sleep | |||
There was a problem hiding this comment.
As discussed offline, right now we can have sleep, but in the future we would like to have something like "WaitForServices" so we don't need to have this sleep.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marseel, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Add sleep to wait for LB resources to be cleaned up, before deleting
In the current state, cluster gets deleted, and 10 minutes (default wait to clean up resources) is not enough to remove all LBs and Deployments, that is why tests are failing