Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to registry.k8s.io #2232

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

Reference issue:
  - kubernetes#2231

Part of:
  - kubernetes/k8s.io#4738

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2023
@mborsz
Copy link
Member

mborsz commented Feb 14, 2023

/hold

We have had some problems with using registry.k8s.io in testing environments without public internet access.
We need to test this change in such environment before merging or adapt the tests running there to have access to registry.k8s.io.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2023
@ameukam
Copy link
Member Author

ameukam commented Feb 14, 2023

testing environments without public internet access.

which environments are we talking about ? related to the Kubernetes project ?

@mborsz
Copy link
Member

mborsz commented Feb 14, 2023

The last time this change has broken GKE internal tests (#2044) which are using private nodes without internet access. I'm not sure what is a state now and if we expect to registry.k8s.io to work in such cases. I asked the current oncall to investigate this issue.

@aojea
Copy link
Member

aojea commented Feb 14, 2023

The last time this change has broken GKE internal tests (#2044) which are using private nodes without internet access. I'm not sure what is a state now and if we expect to registry.k8s.io to work in such cases. I asked the current oncall to investigate this issue.

cc: @BenTheElder

@BenTheElder
Copy link
Member

So from an OSS perspective, GKE internal test environment issues should really not be blocking upstream changes unless they're surfacing a bug ...

Kubernetes has a merged KEP to cease allowing any new images in GCR for 1.27+, and SIG K8s Infra could choose to shut down GCR even sooner as all images are available at registry.k8s.io and Kubernetes is massively over-budget (think $4M spend rate on $3M GCP budget), primarily due to content download costs.

Kubernetes has been on registry.k8s.io since 1.25, released August '22.

I see the internal bug and will follow-up on GKE's options there.

@Argh4k
Copy link
Contributor

Argh4k commented Feb 16, 2023

Hi, we updated gke internal tests and we are ready to go with this change.

@ameukam
Copy link
Member Author

ameukam commented Feb 16, 2023

@mborsz @marseel @wojtek-t PTAL.

@marseel
Copy link
Member

marseel commented Feb 16, 2023

/approve
but waiting for someone from GKE team to unhold when they are ready to merge.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
@aojea
Copy link
Member

aojea commented Feb 16, 2023

as a followup we should update the pause image version, right now kubernetes uses the 3.9 version and this repo seems to be useing 3.1 , I don't know if that can be an issue though

@BenTheElder
Copy link
Member

BenTheElder commented Feb 16, 2023

/lgtm
yeah, pause can be a separate PR, I doubt this repo depends on the newer features of pause and it's orthogonal

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BenTheElder, marseel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Argh4k
Copy link
Contributor

Argh4k commented Feb 17, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 136a78e into kubernetes:master Feb 17, 2023
@vaibhav2107
Copy link
Member

Fixes: #2231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants