-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to registry.k8s.io #2232
Conversation
Reference issue: - kubernetes#2231 Part of: - kubernetes/k8s.io#4738 Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
/hold We have had some problems with using registry.k8s.io in testing environments without public internet access. |
which environments are we talking about ? related to the Kubernetes project ? |
The last time this change has broken GKE internal tests (#2044) which are using private nodes without internet access. I'm not sure what is a state now and if we expect to registry.k8s.io to work in such cases. I asked the current oncall to investigate this issue. |
cc: @BenTheElder |
So from an OSS perspective, GKE internal test environment issues should really not be blocking upstream changes unless they're surfacing a bug ... Kubernetes has a merged KEP to cease allowing any new images in GCR for 1.27+, and SIG K8s Infra could choose to shut down GCR even sooner as all images are available at registry.k8s.io and Kubernetes is massively over-budget (think $4M spend rate on $3M GCP budget), primarily due to content download costs. Kubernetes has been on registry.k8s.io since 1.25, released August '22. I see the internal bug and will follow-up on GKE's options there. |
Hi, we updated gke internal tests and we are ready to go with this change. |
/approve |
as a followup we should update the pause image version, right now kubernetes uses the |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, BenTheElder, marseel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Fixes: #2231 |
Reference issue:
Part of:
Signed-off-by: Arnaud Meukam ameukam@gmail.com