Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WaitForGenericK8sObjects measurement #2313

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Add WaitForGenericK8sObjects measurement #2313

merged 1 commit into from
Sep 7, 2023

Conversation

kisieland
Copy link
Contributor

The new measurement lists all objects from given resource accesses 'status.conditions' field and compares it with list of expected conditions.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds new measurement WaitForGenericK8sObjects, whicht:

  • Can access any object type, via dynamic client
  • Assumes the objects contain status.conditions field, which is of type []metav1.Condition
  • Periodically checks if enough objects have given conditions fulfilled, e.g. NodeReady=True (or failed e.g. PodFailed=True)
  • Finishes if there are enough objects fulfilling the requirements

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @kisieland!

It looks like this is your first PR to kubernetes/perf-tests 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/perf-tests has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kisieland. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 4, 2023
@tosi3k
Copy link
Member

tosi3k commented Sep 5, 2023

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2023
tosi3k
tosi3k suggested changes Sep 5, 2023
View reviewed changes
Copy link
Member

@tosi3k tosi3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit tests - apart from having control over regressions, they would facilitate understanding the measurement's logic as well.

clusterloader2/pkg/measurement/util/wait_for_conditions.go Outdated Show resolved Hide resolved
clusterloader2/pkg/measurement/common/wait_for_generic_k8s_object.go Outdated Show resolved Hide resolved
clusterloader2/pkg/measurement/util/wait_for_conditions.go Outdated Show resolved Hide resolved
clusterloader2/pkg/measurement/util/object_store_dynamic.go Outdated Show resolved Hide resolved
clusterloader2/pkg/measurement/util/object_store_dynamic.go Outdated Show resolved Hide resolved
clusterloader2/pkg/measurement/util/wait_for_conditions.go Outdated Show resolved Hide resolved
clusterloader2/pkg/measurement/util/wait_for_conditions.go Outdated Show resolved Hide resolved
clusterloader2/pkg/measurement/util/object_store_dynamic.go Outdated Show resolved Hide resolved
@tosi3k
Copy link
Member

tosi3k commented Sep 6, 2023 •
edited
Loading

One more thing - could you add a TL;DR of the measurement to ClusterLoader2's README in https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/README.md#measurement?

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2023
@kisieland
Copy link
Contributor Author

@tosi3k I've added the unit tests, PTAL

@kisieland
Copy link
Contributor Author

@tosi3k added entry to the README

@kisieland
Add WaitForGenericK8sObjects measurement
54abd9b 
The new measurement lists all objects from given resource
accesses 'status.conditions' field and compares it with
list of expected conditions.
@kisieland
Copy link
Contributor Author

@tosi3k PTAL

@tosi3k
Copy link
Member

tosi3k commented Sep 7, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kisieland, tosi3k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1f0a1bd into kubernetes:master Sep 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosi3k tosi3k tosi3k requested changes

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@tosi3k tosi3k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kisieland @k8s-ci-robot @tosi3k