-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL2] Follow up to safetext migration #2482
Conversation
Adding StructuralData as some data parsing was broken, only visible when PROMETHEUS_NODE_SELECTOR env was set
Change was tested locally with and without |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jprzychodzen, mborsz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
Adding StructuralData as some data parsing was broken, only visible when PROMETHEUS_NODE_SELECTOR env was set
What type of PR is this?
/kind bug
What this PR does / why we need it:
Using CL2_PROMETHEUS_NODE_SELECTOR no longer breaks Prometheus.
Which issue(s) this PR fixes:
Fix #2464
Follow up to #2421 to cover use case of CL2_PROMETHEUS_NODE_SELECTOR
/assign @mborsz
FYI @hakuna-matatah