Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClusterLoader2 cleanups and improvements #712

Merged
merged 3 commits into from
Jul 30, 2019
Merged

ClusterLoader2 cleanups and improvements #712

merged 3 commits into from
Jul 30, 2019

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Jul 30, 2019

  • Remove IsEven / IsOdd template functions: replaced with eq (Mod a 2) 0/1
  • Make overrides available in object templates - we don't have to pipe overrides to object templates anymore
  • Don't apply empty object template files - this adds ability to easily create an object (e.g. NetworkPolicy) only for X% of deployments

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 30, 2019
@oxddr
Copy link
Contributor

oxddr commented Jul 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, oxddr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f142b4f into kubernetes:master Jul 30, 2019
@wojtek-t
Copy link
Member

lgtm

@mm4tt
Copy link
Contributor Author

mm4tt commented Jul 31, 2019

Ref. #704 - this should help implement NetworkPolicies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysied krzysied Awaiting requested review from krzysied

@oxddr oxddr Awaiting requested review from oxddr

Assignees

@oxddr oxddr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mm4tt @oxddr @k8s-ci-robot @wojtek-t