Make GetReplicasFromRuntimeObject work for DaemonSets #782
Conversation
k8s-ci-robot
added
cncf-cla: yes
mm4tt
force-pushed
the
daemonset_runtime
branch
from
f94f9f3
to
5f72fbf
Compare
| @@ -288,7 +288,7 @@ func GetReplicasFromRuntimeObject(obj runtime.Object) (int32, error) { | |||
| } | |||
| return 0, nil | |||
| case *appsv1.DaemonSet: | |||
| return 0, nil | |||
| return int32(numNodes), nil | |||
There was a problem hiding this comment.
I don't think that's a good way of doing this. In DaemonSet you can set node-selector and then less pods can be created.
So instead of that, I think we should pass a ClientSet to this method and here list nodes with a given label-selector and return this number. I know this has a performance implication, but that isn't something that will be called all the time, and it will be more correct.
mm4tt
force-pushed
the
daemonset_runtime
branch
2 times, most recently
from
c6781b0
to
5aff778
Compare
| return numSchedulableNodes, nil | ||
| } | ||
|
|
||
| // Note: This function assumes each controller has field Spec.Replicas, except Job. |
mm4tt
force-pushed
the
daemonset_runtime
branch
from
5aff778
to
f35d333
Compare
mm4tt
force-pushed
the
daemonset_runtime
branch
from
f35d333
to
5602a6c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is not an ideal solution as it ignores affinity, but it's a good start and for now should fit our needs.
Ref. #704