Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to remove old prometheus snapshots #972

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

jkaniuk
Copy link
Contributor

@jkaniuk jkaniuk commented Jan 7, 2020

Periodic scalability tests save snapshots of prometheus disks.
That script helps with automatic removal of old snapshots so that project quota won't be exhausted.

It should be executed by separate periodic prow job.

/cc mm4tt

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2020
@mm4tt
Copy link
Contributor

mm4tt commented Jan 7, 2020

/assign @oxddr

@oxddr, you are far more proficient with bash than I am. Could you take a look?

@jkaniuk
Copy link
Contributor Author

jkaniuk commented Jan 8, 2020

/test pull-perf-tests-clusterloader2-kubemark

clusterloader2/clean-up-old-snapshots.sh Outdated Show resolved Hide resolved
clusterloader2/clean-up-old-snapshots.sh Outdated Show resolved Hide resolved
clusterloader2/clean-up-old-snapshots.sh Outdated Show resolved Hide resolved
clusterloader2/clean-up-old-snapshots.sh Outdated Show resolved Hide resolved
regexp=$2
days_old=$3
(
set -o xtrace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To print full issued command for observability purposes

@oxddr
Copy link
Contributor

oxddr commented Jan 9, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkaniuk, oxddr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 76de3c3 into kubernetes:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants