Changing Testing behaviour to test non existing branch

cmd/update-rules/main.go

@@ -131,8 +131,8 @@ func UpdateRules(rules *config.RepositoryRules, branch, goVer string, deleteRule
 		var deletedBranch bool
 		// To Check and Remove the existing/deprecated branch
 		if deleteRule {
-			for i, br := range r.Branches {
-				if br.Name == branch {
+			for i := range r.Branches {
+				if rules.Rules[j].Branches[i].Name == branch {
 					glog.Infof("remove rule %s for %s", branch, r.DestinationRepository)
 					rules.Rules[j].Branches = append(rules.Rules[j].Branches[:i], rules.Rules[j].Branches[i+1:]...)
 					deletedBranch = true

cmd/update-rules/main_test.go

@@ -16,7 +16,10 @@ limitations under the License.
 
 package main
 
-import "testing"
+import (
+	"reflect"
+	"testing"
+)
 
 var (
 	testdataRules        = "testdata/rules.yaml"
@@ -166,19 +169,22 @@ func TestUpdateRules(t *testing.T) {
 
 func TestDeleteRules(t *testing.T) {
 	tests := []struct {
-		name      string
-		branch    string
-		goVersion string
+		name          string
+		branch        string
+		goVersion     string
+		isBranchExist bool
 	}{
 		{
 			"deleting rule for non existing branch",
 			"release-1.20",
 			"1.17.1",
+			true,
 		},
 		{
-			"deleting rule for non existing branch",
+			"deleting rule for non existing branch 1.25",
 			"release-1.25",
 			"1.17.1",
+			false,
 		},
 	}
 
@@ -189,13 +195,20 @@ func TestDeleteRules(t *testing.T) {
 				t.Errorf("error loading test rules file %v", err)
 			}
 			UpdateRules(rules, tt.branch, tt.goVersion, true)
-
-			for _, repoRule := range rules.Rules {
-				for _, branchRule := range repoRule.Branches {
-					if branchRule.Name == tt.branch {
-						t.Errorf("failed to delete %s branch rule from for repo %s", tt.name, repoRule.DestinationRepository)
+			if tt.isBranchExist {
+				for _, repoRule := range rules.Rules {
+					for _, branchRule := range repoRule.Branches {
+						if branchRule.Name == tt.branch {
+							t.Errorf("failed to delete %s branch rule from for repo %s", tt.name, repoRule.DestinationRepository)
+						}
 					}
 				}
+			} else {
+				if loadedRules, err := load(testdataRules); err != nil {
+					t.Errorf("error loading test rules file for comparison %v", err)
+				} else if !reflect.DeepEqual(loadedRules, rules) {
+					t.Errorf("rules changed after deleting a non existent branch %s", tt.branch)
+				}
 			}
 		})
 	}