Fix go mod publishing #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
sttts
reviewed
Jun 18, 2019
| @@ -55,30 +55,46 @@ func updateGomodWithTaggedDependencies(tag string, depsRepo []string) (bool, err | |||
| rev := commit.String() | |||
| pseudoVersion := fmt.Sprintf("v0.0.0-%s-%s", commitTime.UTC().Format("20060102150405"), rev[:12]) | |||
|
|
|||
| downloadCommand := exec.Command("go", "mod", "download") | |||
There was a problem hiding this comment.
will this always pick the right go version?
There was a problem hiding this comment.
Not always, but it could if the pseudo version doesn't change. Added a comment.
sttts
reviewed
Jun 18, 2019
k8s-ci-robot
added
size/L
|
/cc @liggitt |
nikhita
changed the title
sttts
reviewed
Jun 19, 2019
sttts
reviewed
Jun 19, 2019
sttts
reviewed
Jun 19, 2019
sttts
reviewed
Jun 19, 2019
The zip file created by go mod download has extra normalization over the zip file created by git archive. The normalization process is done below. While the normalization can also be achieved via a simple zip command, the zip file created by go mod download has the `00-00-1980 00:00` timestamp in the file header for all files in the zip archive. This is not a valid UNIX timestamp and cannot be set easily. This is, however, valid in MSDOS. The `archive/zip` package uses the MSDOS version so we create the zip file using this package.
nikhita
commented
Jun 20, 2019
| @@ -193,11 +193,6 @@ func main() { | |||
| continue | |||
| } | |||
|
|
|||
| // temporarily publish only alpha tags | |||
| if !strings.Contains(bName, "alpha") { | |||
There was a problem hiding this comment.
Removed the alpha tags restriction. PTAL.
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes:
exec.Command.go mod downloadbefore packaging up a dependency and before updating the require and replace directives. This will help in avoiding packaging up, when the pseudo version is the same but we don't have it in the local cache.gomod-zipfor creating the zip file that would have the same hash as that of the zip file if it were downloaded bygo mod download. The zip file created by gomod differs from the former:-xand-Doptions.00-00-1980 00:00timestamp in the file header for all files in the zip archive. This is not a valid UNIX timestamp and cannot be set easily. This is, however, valid in MSDOS. Thearchive/zippackage uses the MSDOS version so we create the zip file using this package.git archive: go uses this.archive/zippackage to re-create the zip file from that created usinggit archive.For the record: we had to do a
GO111MODULE=on go mod clean -modcachefirst to clear the old zip files in our cache. Did this throughkubectl exec, not using this PR.For additional context, this slack thread has more details.
/hold
doesn't fix the error yet, but I figured I'll open a PR to get my latest changes in