Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gcloud config get-value instead of parsing the list output. #331

Merged
merged 1 commit into from
May 22, 2017
Merged

Use gcloud config get-value instead of parsing the list output. #331

merged 1 commit into from
May 22, 2017

Conversation

david-mcmahon
Copy link
Contributor

@david-mcmahon david-mcmahon requested a review from ixdy May 22, 2017 22:09
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2017
dclaar
dclaar approved these changes May 22, 2017
View reviewed changes
Copy link
Contributor

@dclaar dclaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@david-mcmahon david-mcmahon merged commit 93ae413 into kubernetes:master May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dclaar dclaar dclaar approved these changes

@ixdy ixdy Awaiting requested review from ixdy

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-mcmahon @dclaar @k8s-ci-robot