Get canonical list of blocking jobs from test-infra/config/config.yaml. #341
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
david-mcmahon
force-pushed
the
release-blocking
branch
3 times, most recently
from
aeb5778
to
62f5fda
Compare
david-mcmahon
changed the title
david-mcmahon
force-pushed
the
release-blocking
branch
from
62f5fda
to
c76d79c
Compare
| # Due to resetting $branch above based on branch==master to workaround | ||
| # inconsistencies in the testgrid config naming conventions, now look | ||
| # *specifically* for a release branch with a version in it (non-master). | ||
| if [[ "$branch" =~ release-([0-9]{1,})\. ]]; then |
There was a problem hiding this comment.
Curious what does "," mean?
There was a problem hiding this comment.
{1,} == one or more occurrences of the previous pattern.
|
It seems good. We can always fix script problems when we run the tool. |
| "Run the following and try again:" | ||
| logecho | ||
| for prereq in ${missing[@]}; do | ||
| logecho "$ sudo pip install install $prereq" |
|
Thanks @caesarxuchao and @enisoc. All comments addressed. PTAL. |
|
Did you not push the updated branch yet? In any case it was just a nit. /lgtm |
k8s-ci-robot
added
the
lgtm
| # Loop through the remainder, excluding anything specified by --exclude_suites | ||
| for ((i=1;i<=${#all_jobs[*]};i++)); do | ||
| re="\\b${all_jobs[$i]}\\b" | ||
| [[ ${exclude_suites[*]} =~ $re ]] || secondary_jobs+=(${all_jobs[$i]}) |
There was a problem hiding this comment.
Can we swap re and exclude-suites, so that we can use regular expression in the excluded list?
There was a problem hiding this comment.
If we have to exclude that many tests, I'm going to suggest that the -blocking set isn't accurately representative. That said, it's easy enough to remove the word boundary "\b" in the regex and let it search more greedily.
Update OWNERS_ALIASES to only include N-3 RT personnel
Companion change to kubernetes/test-infra#3028.
cc @kubernetes/kubernetes-release-managers