Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental etcd image for 5k node scalability tests #12710

Merged
merged 1 commit into from
May 19, 2019

Conversation

wojtek-t
Copy link
Member

We have an experimental etcd image that is adding support for "Concurrent Reads". I believe that this should help with the issues that we're currently facing with density test.

I propose to enable this for one or two runs of 5k-node tests. With this we would hit two birds with one stone:

  • we will verify the performance impact of that change to Kubernetes
  • we will see if the problems with density test are really mostly caused by etcd (in which case they should be mitigated) [i.e. we know those are triggerred by taint manager, but the question is what is happening when processing its LIST pods requests]

/assign @mborsz

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2019
@k8s-ci-robot k8s-ci-robot requested review from mborsz and mm4tt May 19, 2019 15:21
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2019
@mm4tt
Copy link
Contributor

mm4tt commented May 19, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cd557962e27b81ff72693f02847caf9301d0f64f

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 784763b into kubernetes:master May 19, 2019
@k8s-ci-robot
Copy link
Contributor

@wojtek-t: Updated the job-config configmap in namespace default using the following files:

  • key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml

In response to this:

We have an experimental etcd image that is adding support for "Concurrent Reads". I believe that this should help with the issues that we're currently facing with density test.

I propose to enable this for one or two runs of 5k-node tests. With this we would hit two birds with one stone:

  • we will verify the performance impact of that change to Kubernetes
  • we will see if the problems with density test are really mostly caused by etcd (in which case they should be mitigated) [i.e. we know those are triggerred by taint manager, but the question is what is happening when processing its LIST pods requests]

/assign @mborsz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mm4tt added a commit to mm4tt/test-infra that referenced this pull request May 22, 2019
mm4tt added a commit to mm4tt/test-infra that referenced this pull request May 22, 2019
chases2 pushed a commit to chases2/test-infra that referenced this pull request Jun 4, 2019
@wojtek-t wojtek-t deleted the etcd_experiment branch July 19, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants