Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Azure: remove Azure CLI installation step"" #18403

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Revert "Revert "Azure: remove Azure CLI installation step"" #18403

merged 1 commit into from
Aug 6, 2020

Conversation

chewong
Copy link
Member

@chewong chewong commented Jul 21, 2020

Reverts #18366

/assign @feiskyer

@chewong
Copy link
Member Author

chewong commented Jul 21, 2020

/cc @andyzhangx

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubetest sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 21, 2020
@andyzhangx
Copy link
Member

/hold
hold on a moment, and thanks for the fix

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@andyzhangx
Copy link
Member

@chewong wait a moment, looks like I need to convert smb csi driver to use docker buildx as well:
https://github.com/kubernetes-csi/csi-driver-smb/blob/master/Makefile#L108-L110

@chewong chewong mentioned this pull request Aug 3, 2020
Merged
4 tasks
@chewong
Copy link
Member Author

chewong commented Aug 5, 2020

@feiskyer PTAL

@feiskyer
Copy link
Member

feiskyer commented Aug 6, 2020

@chewong @andyzhangx are we ready to remove it now?

@andyzhangx
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2020
andyzhangx
andyzhangx approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2020
@feiskyer
Copy link
Member

feiskyer commented Aug 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, chewong, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit da6d139 into kubernetes:master Aug 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 6, 2020
@aramase aramase mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@feiskyer feiskyer

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubetest cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@chewong @andyzhangx @feiskyer @k8s-ci-robot