Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove restart kubelet flag from e2e lock contention #22836

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Remove restart kubelet flag from e2e lock contention #22836

merged 2 commits into from
Aug 11, 2021

Conversation

ipochi
Copy link
Contributor

@ipochi ipochi commented Jul 9, 2021 •
edited
Loading

The flag --restart-kubelet was added to the test suite in kubernetes/kubernetes#97028

However as it turns out, in order to test the exit on lock contention, it is not needed, hence removing the flag from the test job.

The corresponding PR for the e2e test is kubernetes/kubernetes#103608.

Locally the test can be tested without requiring the --restart-kubelet flag

make test-e2e-node REMOTE=false TEST_ARGS="--kubelet-flags=\"--lock-file=/var/run/kubelet.lock --exit-on-lock-contention --v 4\"" FOCUS="\[NodeFeature:LockContention\]" SKIP="\[Flaky\]|\[Serial\]"

/cc @knabben @rata

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2021
@knabben
Copy link
Member

knabben commented Jul 9, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2021
SergeyKanzhelev
SergeyKanzhelev approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ipochi ipochi force-pushed the imran/remove-restart-kubelet-flag-from-e2e-lock-contention branch from 4b68696 to aace05a Compare July 9, 2021 17:30
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2021
SergeyKanzhelev
SergeyKanzhelev approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2021
@ipochi
Copy link
Contributor Author

ipochi commented Jul 10, 2021

/assign @mrunalp

@mrunalp Please provide your feedback and merge.

@ipochi
Copy link
Contributor Author

ipochi commented Jul 26, 2021

@SergeyKanzhelev @mrunalp

friendly ping.

@ipochi
Copy link
Contributor Author

ipochi commented Aug 4, 2021

@derekwaynecarr @mrunalp @SergeyKanzhelev
friendly ping.

@ipochi
Copy link
Contributor Author

ipochi commented Aug 11, 2021

Looking to get this merged. Please anyone approve the PR.

@yujuhong
@Random-Liu
@dchen1107
@derekwaynecarr
@sjenning
@mrunalp
@klueska
@ehashman
@SergeyKanzhelev

@ipochi ipochi mentioned this pull request Aug 11, 2021
Merged
@ipochi
remove restart-kubelet flag.
6030e03 
This flag was added to the test suite in
kubernetes/kubernetes#97028

However as it turns out, in order to test the exit on lock contention,
it is not needed, hence removing the flag from the test job.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
@ipochi
add skip to override default skip value
63bcbbf 
If skip is not provided that the default value of skip makes our test
also get skipped.

This overrides the default skip to empty.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
@ipochi ipochi force-pushed the imran/remove-restart-kubelet-flag-from-e2e-lock-contention branch from aace05a to 63bcbbf Compare August 11, 2021 09:13
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ipochi, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@pacoxu
Copy link
Member

pacoxu commented Aug 11, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 304f0c8 into kubernetes:master Aug 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

@ipochi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

The flag --restart-kubelet was added to the test suite in kubernetes/kubernetes#97028

However as it turns out, in order to test the exit on lock contention, it is not needed, hence removing the flag from the test job.

The corresponding PR for the e2e test is kubernetes/kubernetes#103608.

Locally the test can be tested without requiring the --restart-kubelet flag

make test-e2e-node REMOTE=false TEST_ARGS="--kubelet-flags=\"--lock-file=/var/run/kubelet.lock --exit-on-lock-contention --v 4\"" FOCUS="\[NodeFeature:LockContention\]" SKIP="\[Flaky\]|\[Serial\]"

/cc @knabben @rata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ipochi ipochi deleted the imran/remove-restart-kubelet-flag-from-e2e-lock-contention branch August 11, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

Assignees

@mrunalp mrunalp

@knabben knabben

@pacoxu pacoxu

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Archived in project
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
6 participants
@ipochi @knabben @k8s-ci-robot @pacoxu @SergeyKanzhelev @mrunalp