Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated deadcode with unused lint check from golangci-lint #27775

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Replace deprecated deadcode with unused lint check from golangci-lint #27775

merged 2 commits into from
Oct 20, 2022

Conversation

xdu31
Copy link
Contributor

@xdu31 xdu31 commented Oct 19, 2022

Replace deprecated deadcode with unused lint check from golangci-lint
Resolution to #27759

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 19, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xdu31 / name: Jason Du (4be69a8)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 19, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @xdu31!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 19, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @xdu31. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 19, 2022
@xdu31 xdu31 changed the title Replace deprecated deadcode with unused lint check from golangci-lint Replace deprecated deadcode with unused eiifccujibvtdhijrruvulbkthibejjfunidnhntlrecihuu check from golangci-lint Oct 19, 2022
@xdu31 xdu31 changed the title Replace deprecated deadcode with unused eiifccujibvtdhijrruvulbkthibejjfunidnhntlrecihuu check from golangci-lint Replace deprecated deadcode with unused lint check from golangci-lint Oct 19, 2022
@dims
Copy link
Member

dims commented Oct 19, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) area/kubetest area/prow Issues or PRs related to prow area/prow/crier Issues or PRs related to prow's crier component area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/hook Issues or PRs related to prow's hook component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component area/prow/mkpj Issues or PRs related to prow's mkpj component size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/prow/plank Issues or PRs related to prow's plank component and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2022
@k8s-ci-robot k8s-ci-robot added area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow/sinker Issues or PRs related to prow's sinker component area/prow/spyglass Issues or PRs related to prow's spyglass UI area/prow/tide Issues or PRs related to prow's tide component area/robots Issues or PRs related to code in /robots labels Oct 20, 2022
@dims
Copy link
Member

dims commented Oct 20, 2022

/approve
/lgtm

thanks @xdu31 Congrats on your first PR here!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xdu31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 96ba491 into kubernetes:master Oct 20, 2022
@jbpratt jbpratt mentioned this pull request Oct 23, 2022
Closed
@xdu31 xdu31 mentioned this pull request Mar 16, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp Awaiting requested review from spiffxp

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) area/kubetest area/prow/crier Issues or PRs related to prow's crier component area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/hook Issues or PRs related to prow's hook component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component area/prow/mkpj Issues or PRs related to prow's mkpj component area/prow/plank Issues or PRs related to prow's plank component area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow/sinker Issues or PRs related to prow's sinker component area/prow/spyglass Issues or PRs related to prow's spyglass UI area/prow/tide Issues or PRs related to prow's tide component area/prow Issues or PRs related to prow area/robots Issues or PRs related to code in /robots cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xdu31 @k8s-ci-robot @dims