Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync -release-blocking dashboards with kubernetes/release/lib/releaselib.sh #3028

Merged
merged 1 commit into from
Jun 19, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
235 changes: 67 additions & 168 deletions testgrid/config/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1995,6 +1995,8 @@ dashboards:
test_group_name: ci-kubernetes-e2e-gce-reboot-release-1-6
- name: gce-1.6
test_group_name: ci-kubernetes-e2e-gce-release-1-6
- name: federation-build-1.6
test_group_name: ci-kubernetes-federation-build-1.6
- name: gce-scalability-1.6
test_group_name: ci-kubernetes-e2e-gce-scalability-release-1.6
- name: gce-serial-1.6
Expand Down Expand Up @@ -2054,167 +2056,70 @@ dashboards:
- name: periodic-kubeadm-gce-1.6
test_group_name: periodic-kubernetes-e2e-kubeadm-gce-1-6

# Matches the list on https://github.com/kubernetes/test-infra/issues/2029
# These are the release *blocking* tests. These provide a valid binary signal
# to gate releases (alpha, beta, official).
# This list is used by kubernetes/release/lib/releaselib.sh to provide go/nogo
# signal for releases.
# The first test/suite in the list is the primary suite for release purposes
- name: release-1.6-blocking
dashboard_tab:
# Build/Verify
- name: build-1.6
test_group_name: ci-kubernetes-build-1.6
- name: verify-1.6
test_group_name: ci-kubernetes-verify-release-1.6
- name: test-go-1.6
test_group_name: ci-kubernetes-test-go-release-1.6
- name: federation-build-1.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to release-1.6-all? It's not there yet and I don't want it to fall out entirely.

test_group_name: ci-kubernetes-federation-build-1.6
# E2E
- name: gce-1.6
test_group_name: ci-kubernetes-e2e-gce-release-1-6
- name: gci-gce-1.6
test_group_name: ci-kubernetes-e2e-gci-gce-release-1-6
- name: gke-1.6
test_group_name: ci-kubernetes-e2e-gke-release-1-6
- name: gci-gke-1.6
test_group_name: ci-kubernetes-e2e-gci-gke-release-1-6
- name: kubeadm-gce-1.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to release-1.6-all? It's not there yet and I don't want it to fall out entirely.

test_group_name: ci-kubernetes-e2e-kubeadm-gce-1-6
# AWS
- name: kops-aws-1.6
test_group_name: ci-kubernetes-e2e-kops-aws-release-1.6
# Slow
- name: gce-slow-1.6
test_group_name: ci-kubernetes-e2e-gce-slow-release-1-6
- name: gci-gce-slow-1.6
test_group_name: ci-kubernetes-e2e-gci-gce-slow-release-1-6
- name: gke-slow-1.6
test_group_name: ci-kubernetes-e2e-gke-slow-release-1-6
- name: gci-gke-slow-1.6
test_group_name: ci-kubernetes-e2e-gci-gke-slow-release-1-6
# Serial
- name: gce-serial-1.6
test_group_name: ci-kubernetes-e2e-gce-serial-release-1-6
- name: gci-gce-serial-1.6
test_group_name: ci-kubernetes-e2e-gci-gce-serial-release-1-6
- name: gke-serial-1.6
test_group_name: ci-kubernetes-e2e-gke-serial-release-1-6
- name: gci-gke-serial-1.6
test_group_name: ci-kubernetes-e2e-gci-gke-serial-release-1-6
# Alpha
- name: gce-alpha-features-1.6
test_group_name: ci-kubernetes-e2e-gce-alpha-features-release-1-6
- name: gci-gce-alpha-features-1.6
test_group_name: ci-kubernetes-e2e-gci-gce-alpha-features-release-1-6
# Scalability
- name: gce-scalability-1.6
test_group_name: ci-kubernetes-e2e-gce-scalability-release-1.6
- name: gci-gce-scalability-1.6
test_group_name: ci-kubernetes-e2e-gci-gce-scalability-release-1.6
# Ingress
- name: gci-gce-ingress-1.6
test_group_name: ci-kubernetes-e2e-gci-gce-ingress-release-1-6
- name: gci-gke-ingress-1.6
test_group_name: ci-kubernetes-e2e-gci-gke-ingress-release-1-6
# Reboot
- name: gce-slow-1.6
test_group_name: ci-kubernetes-e2e-gce-slow-release-1-6
- name: gce-reboot-1.6
test_group_name: ci-kubernetes-e2e-gce-reboot-release-1-6
- name: gci-gce-reboot-1.6
test_group_name: ci-kubernetes-e2e-gci-gce-reboot-release-1-6
- name: gke-reboot-1.6
test_group_name: ci-kubernetes-e2e-gke-reboot-release-1-6
- name: gci-gke-reboot-1.6
test_group_name: ci-kubernetes-e2e-gci-gke-reboot-release-1-6
# Soak
- name: ci-kubernetes-soak-gce-1.6-deploy
test_group_name: ci-kubernetes-soak-gce-1.6-deploy
- name: ci-kubernetes-soak-gce-1.6-test
test_group_name: ci-kubernetes-soak-gce-1.6-test
- name: ci-kubernetes-soak-gci-gce-1.6-deploy
test_group_name: ci-kubernetes-soak-gci-gce-1.6-deploy
- name: ci-kubernetes-soak-gci-gce-1.6-test
test_group_name: ci-kubernetes-soak-gci-gce-1.6-test
# Node
- name: gce-scalability-1.6
test_group_name: ci-kubernetes-e2e-gce-scalability-release-1.6
- name: test-go-1.6
test_group_name: ci-kubernetes-test-go-release-1.6
- name: verify-1.6
test_group_name: ci-kubernetes-verify-release-1.6
- name: kubelet-1.6
test_group_name: ci-kubernetes-node-kubelet-1.6
- name: kubelet-non-cri-1.6
test_group_name: ci-kubernetes-node-kubelet-non-cri-1.6
- name: gke-serial-1.6
test_group_name: ci-kubernetes-e2e-gke-serial-release-1-6
- name: gke-1.6
test_group_name: ci-kubernetes-e2e-gke-release-1-6
- name: gke-slow-1.6
test_group_name: ci-kubernetes-e2e-gke-slow-release-1-6

# These are the master *blocking* tests. These provide a valid binary signal
# to gate releases (alpha, beta, official).
# This list is used by kubernetes/release/lib/releaselib.sh to provide go/nogo
# signal for releases.
# The first test/suite in the list is the primary suite for release purposes
# Blocking tests for the next release
- name: release-master-blocking
dashboard_tab:
# Build/Verify
- name: build
test_group_name: ci-kubernetes-build
- name: gce
test_group_name: ci-kubernetes-e2e-gce
- name: gce-serial
test_group_name: ci-kubernetes-e2e-gce-serial
- name: gce-slow
test_group_name: ci-kubernetes-e2e-gce-slow
- name: gce-reboot
test_group_name: ci-kubernetes-e2e-gce-reboot
- name: gce-scalability
test_group_name: ci-kubernetes-e2e-gce-scalability
- name: test-go
test_group_name: ci-kubernetes-test-go
- name: verify-master
- name: verify
test_group_name: ci-kubernetes-verify-master
- name: kubelet
test_group_name: ci-kubernetes-node-kubelet
- name: federation-build
test_group_name: ci-kubernetes-federation-build
- name: gce
test_group_name: ci-kubernetes-e2e-gce
- name: gce-etcd3
test_group_name: ci-kubernetes-e2e-gce-etcd3
- name: gci-gce
test_group_name: ci-kubernetes-e2e-gci-gce
- name: gke
test_group_name: ci-kubernetes-e2e-gke
- name: gci-gke
test_group_name: ci-kubernetes-e2e-gci-gke
- name: aws
test_group_name: ci-kubernetes-e2e-kops-aws
- name: gce-gpu
test_group_name: ci-kubernetes-e2e-gce-gpu
- name: gce-slow
test_group_name: ci-kubernetes-e2e-gce-slow
- name: gci-gce-slow
test_group_name: ci-kubernetes-e2e-gci-gce-slow
- name: gke-slow
test_group_name: ci-kubernetes-e2e-gke-slow
- name: gci-gke-slow
test_group_name: ci-kubernetes-e2e-gci-gke-slow
- name: gce-serial
test_group_name: ci-kubernetes-e2e-gce-serial
- name: gci-gce-serial
test_group_name: ci-kubernetes-e2e-gci-gce-serial
- name: gke-serial
test_group_name: ci-kubernetes-e2e-gke-serial
- name: gci-gke-serial
test_group_name: ci-kubernetes-e2e-gci-gke-serial
- name: gce-federation
test_group_name: ci-kubernetes-e2e-gce-federation
- name: gce-alpha-features
test_group_name: ci-kubernetes-e2e-gce-alpha-features
- name: gci-gce-alpha-features
test_group_name: ci-kubernetes-e2e-gci-gce-alpha-features
- name: gce-audit
test_group_name: ci-kubernetes-e2e-gce-audit
- name: gci-gce-audit
test_group_name: ci-kubernetes-e2e-gci-gce-audit
- name: gce-scalability
test_group_name: ci-kubernetes-e2e-gce-scalability
- name: gci-gce-scalability
test_group_name: ci-kubernetes-e2e-gci-gce-scalability
- name: gci-gce-ingress
test_group_name: ci-kubernetes-e2e-gci-gce-ingress
- name: gci-gke-ingress
test_group_name: ci-kubernetes-e2e-gci-gke-ingress
- name: gce-reboot
test_group_name: ci-kubernetes-e2e-gce-reboot
- name: gci-gce-reboot
test_group_name: ci-kubernetes-e2e-gci-gce-reboot
- name: gke-reboot
test_group_name: ci-kubernetes-e2e-gke-reboot
- name: gci-gke-reboot
test_group_name: ci-kubernetes-e2e-gci-gke-reboot
- name: soak-gce-deploy
test_group_name: ci-kubernetes-soak-gce-deploy
- name: soak-gce-test
test_group_name: ci-kubernetes-soak-gce-test
- name: soak-gce-gci-deploy
test_group_name: ci-kubernetes-soak-gce-gci-deploy
- name: soak-gce-gci-test
test_group_name: ci-kubernetes-soak-gce-gci-test

- name: release-1.6-upgrade-skew
dashboard_tab:
Expand Down Expand Up @@ -2750,82 +2655,76 @@ dashboards:
- name: periodic-bazel-test-1.7
test_group_name: periodic-kubernetes-bazel-test-1-7

# These are the release *blocking* tests. These provide a valid binary signal
# to gate releases (alpha, beta, official).
# This list is used by kubernetes/release/lib/releaselib.sh to provide go/nogo
# signal for releases.
# The first test/suite in the list is the primary suite for release purposes
- name: release-1.7-blocking
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add three more:

  1. kubelet-serial-gce-e2e-1-7
  2. gke-gci-gpu-1-7
  3. gce-gci-auth-1-7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These looks like brand new variants, not just something to move into -blocking. That seems to be outside the scope of this PR. Post-this, anyone can add those new suites and put them into blocking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not difficult, let's just add them in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added these. As these are brand new test suites and not just moving things around, I have little confidence I did it correctly. Please check carefully.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-mcmahon let's add these three into the panel. @dchen1107 says there are PRs creating these tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't add them until the PR goes in that includes them. Let's just get this in now. We can iterate.

dashboard_tab:
- name: build-1.7
test_group_name: ci-kubernetes-build-1.7
- name: gce-release-1-7
test_group_name: ci-kubernetes-e2e-gce-release-1-7
- name: gce-serial-release-1-7
test_group_name: ci-kubernetes-e2e-gce-serial-release-1-7
- name: gce-slow-release-1-7
test_group_name: ci-kubernetes-e2e-gce-slow-release-1-7
- name: gce-reboot-release-1-7
test_group_name: ci-kubernetes-e2e-gce-reboot-release-1-7
- name: gce-scalability-release-1-7
test_group_name: ci-kubernetes-e2e-gce-scalability-release-1-7
- name: test-go-1.7
test_group_name: ci-kubernetes-test-go-release-1.7
- name: verify-1.7
test_group_name: ci-kubernetes-verify-release-1.7
- name: gce-kubeadm-1.7
test_group_name: ci-kubernetes-e2e-kubeadm-gce-1-7
- name: kubelet-1.7
test_group_name: ci-kubernetes-node-kubelet-1.7
- name: federation-build-1.7
test_group_name: ci-kubernetes-federation-build-1.7
- name: gce-release-1-7
test_group_name: ci-kubernetes-e2e-gce-release-1-7
- name: gci-gce-release-1-7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dchen1107 do we need all the gci-, gke-, gci-gke- version of all the tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure? This is up to all of you @kubernetes/kubernetes-release-managers. Remember the goal here when coming up with a set of HARD gating tests, is that you can get a passing set with some regularity as the point is to block the release. Don't add anything here that's just "been failing forever". And the suites may differ between branches (master vs. release-*).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we need all of them. But in long term, I wish we can remove gke related or treat them differently in gke release cycle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of those? Can you be more specific? There are LOTS of suites that fit the gci variant. Are all of those passing enough to provide a good signal at this point? Should whatever that list ends up being be the same for 1.7 and master (and 1.6 for that matter)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean all gci-,gke-,gci-gke- tests that were in the 1.7-blocking should remain there.

test_group_name: ci-kubernetes-e2e-gci-gce-release-1-7
- name: gke-release-1-7
test_group_name: ci-kubernetes-e2e-gke-release-1-7
- name: gci-gke-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gke-release-1-7
- name: aws-release-1-7
test_group_name: ci-kubernetes-e2e-kops-aws-release-1-7
- name: gce-slow-release-1-7
test_group_name: ci-kubernetes-e2e-gce-slow-release-1-7
- name: gci-gce-slow-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gce-slow-release-1-7
- name: gke-serial-release-1-7
test_group_name: ci-kubernetes-e2e-gke-serial-release-1-7
- name: gke-release-1-7
test_group_name: ci-kubernetes-e2e-gke-release-1-7
- name: gce-alpha-features-release-1-7
test_group_name: ci-kubernetes-e2e-gce-alpha-features-release-1-7
- name: gke-slow-release-1-7
test_group_name: ci-kubernetes-e2e-gke-slow-release-1-7
- name: gce-federation-release-1-7
test_group_name: ci-kubernetes-e2e-gce-federation-release-1-7
- name: gci-gce-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gce-release-1-7
- name: gci-gce-slow-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gce-slow-release-1-7
- name: gci-gke-slow-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gke-slow-release-1-7
- name: gce-serial-release-1-7
test_group_name: ci-kubernetes-e2e-gce-serial-release-1-7
- name: gci-gce-serial-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gce-serial-release-1-7
- name: gke-serial-release-1-7
test_group_name: ci-kubernetes-e2e-gke-serial-release-1-7
- name: gci-gke-serial-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gke-serial-release-1-7
- name: gce-federation-release-1-7
test_group_name: ci-kubernetes-e2e-gce-federation-release-1-7
- name: gce-alpha-features-release-1-7
test_group_name: ci-kubernetes-e2e-gce-alpha-features-release-1-7
- name: gci-gce-alpha-features-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gce-alpha-features-release-1-7
- name: gce-audit-release-1-7
test_group_name: ci-kubernetes-e2e-gce-audit-release-1-7
- name: gci-gce-audit-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gce-audit-release-1-7
- name: gce-scalability-release-1-7
test_group_name: ci-kubernetes-e2e-gce-scalability-release-1-7
- name: gci-gce-scalability-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gce-scalability-release-1-7
- name: gci-gce-ingress-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gce-ingress-release-1-7
- name: gci-gke-ingress-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gke-ingress-release-1-7
- name: gce-reboot-release-1-7
test_group_name: ci-kubernetes-e2e-gce-reboot-release-1-7
- name: gci-gce-reboot-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gce-reboot-release-1-7
- name: gke-reboot-release-1-7
test_group_name: ci-kubernetes-e2e-gke-reboot-release-1-7
- name: gci-gke-reboot-release-1-7
test_group_name: ci-kubernetes-e2e-gci-gke-reboot-release-1-7
- name: soak-gce-1-7-deploy
test_group_name: ci-kubernetes-soak-gce-1-7-deploy
- name: soak-gce-1-7-test
test_group_name: ci-kubernetes-soak-gce-1-7-test
- name: soak-gci-gce-1-7-deploy
test_group_name: ci-kubernetes-soak-gci-gce-1-7-deploy
- name: soak-gci-gce-1-7-test
test_group_name: ci-kubernetes-soak-gci-gce-1-7-test
- name: gce-gpu-1-7
test_group_name: ci-kubernetes-e2e-gce-gpu-1-7
- name: gce-kubeadm-1.7
test_group_name: ci-kubernetes-e2e-kubeadm-gce-1-7


- name: cos-image-validation
dashboard_tab:
Expand Down