Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sticky footer issue #10681

Merged
merged 6 commits into from
Feb 28, 2019
Merged

Fix sticky footer issue #10681

merged 6 commits into from
Feb 28, 2019

Conversation

lucperkins
Copy link
Contributor

On pages like the 404 page there's an issue where the footer doesn't stick to the bottom of the page the way that it should. In addition, on pages like the home page there's a band of whitespace at the bottom. This PR fixes both of those issues using Flexbox.

@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 19, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 98826dd

https://deploy-preview-10681--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 19, 2018 •
edited by netlify bot
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d9d7224

https://deploy-preview-10681--kubernetes-io-master-staging.netlify.com

@jamesgeorge007
Copy link
Contributor

jamesgeorge007 commented Oct 20, 2018 •
edited
Loading

@lucperkins For devices below 1100px it doesn't look promising, especially for mobile devices. I can fix it up for mobile screens 👍

@lucperkins
Copy link
Contributor Author

@jamesgeorge007 What's the issue that you're seeing on mobile?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2018
@Bradamant3
Copy link
Contributor

@lucperkins what's the status of this PR? Does it just need merge conflicts fixed, or is there more work needed for better mobile support?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2018
@lucperkins
Copy link
Contributor Author

@Bradamant3 I just fixed the merge conflicts. I'm still not sure which mobile issues were being referred to above, so I consider this good to go.

@Rajakavitha1
Copy link
Contributor

@Bradamant3 Please Take a Look.

@zparnold
Copy link
Member

@lucperkins We hit the unfortunate issue where there's another conflict. I can help if you want

@Rajakavitha1
Copy link
Contributor

Hi @lucperkins !!!!Looks like there are merge conflicts on this PR. Could you please resolve them?

@lucperkins
Copy link
Contributor Author

@Rajakavitha1 Done

@Rajakavitha1
Copy link
Contributor

/assign @kbarnard10

@Rajakavitha1
Copy link
Contributor

@kbarnard10 could you please take a look and state your approval.

@zparnold
Copy link
Member

@lucperkins Looks good to me!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0650b70 into kubernetes:master Feb 28, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@lucperkins
Fix sticky footer issue (kubernetes#10681)
f7a7213 
* Fix sticky footer issue

* Fix merge conflict

* Aesthetic changes to 404 page
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@lucperkins
Fix sticky footer issue (kubernetes#10681)
f225b83 
* Fix sticky footer issue

* Fix merge conflict

* Aesthetic changes to 404 page
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@lucperkins @yagonobre
Fix sticky footer issue (kubernetes#10681)
c39ce8d 
* Fix sticky footer issue

* Fix merge conflict

* Aesthetic changes to 404 page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@zparnold zparnold

@kbarnard10 kbarnard10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lucperkins @k8sio-netlify-preview-bot @jamesgeorge007 @Bradamant3 @Rajakavitha1 @zparnold @k8s-ci-robot @kbarnard10 @kubernetes-docs-i18n-bot