-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description about local http proxy setting's effect on liveness probe #11567
Conversation
4590b6c
to
64a954e
Compare
Deploy preview for kubernetes-io-master-staging ready! Built with commit 4590b6c https://deploy-preview-11567--kubernetes-io-master-staging.netlify.com |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 2d9ef5d https://deploy-preview-11567--kubernetes-io-master-staging.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @WanLinghao Just a few minor changes.
In releases prior to v1.13 and in v1.13, if http_proxy
or HTTP_PROXY
environment variables is set in the node on which a pod is running, the http liveness probe uses that proxy. In the releases after v1.13, local http proxy envirnment variables do not effect the http liveness probe.
64a954e
to
dc8909f
Compare
@Rajakavitha1 Done PTAL |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…robe (kubernetes#11567) * Add description about local http proxy setting's effect on liveness probe * Update configure-liveness-readiness-probes.md
…robe (kubernetes#11567) * Add description about local http proxy setting's effect on liveness probe * Update configure-liveness-readiness-probes.md
…robe (kubernetes#11567) * Add description about local http proxy setting's effect on liveness probe * Update configure-liveness-readiness-probes.md
…robe (kubernetes#11567) * Add description about local http proxy setting's effect on liveness probe * Update configure-liveness-readiness-probes.md
…robe (kubernetes#11567) * Add description about local http proxy setting's effect on liveness probe * Update configure-liveness-readiness-probes.md
Add description about local http proxy setting's effect on liveness probe
ref:kubernetes/kubernetes#68663