Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document owner ref restrictions explicitly #12543

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Document owner ref restrictions explicitly #12543

merged 1 commit into from
Feb 13, 2019

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Feb 7, 2019 •
edited
Loading

This is not a new feature, just an undocumented old behavior.

cc @caesarxuchao @liggitt

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2019
@janetkuo janetkuo mentioned this pull request Feb 7, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Feb 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@netlify
Copy link

netlify bot commented Feb 7, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 45ea92b

https://deploy-preview-12543--kubernetes-io-master-staging.netlify.com

@huyhg
Copy link

huyhg commented Feb 7, 2019

Thanks! Can we also update the type so that the generated API doc, like this here, also has this information?

kbhawkey
kbhawkey reviewed Feb 7, 2019
View reviewed changes
content/en/docs/concepts/workloads/controllers/garbage-collection.md Outdated
@@ -60,6 +60,12 @@ metadata:
...
```

{{< note >}}
Owner references allow resources in the same namespace as the dependents, or
cluster-scoped resources. However, cross-namespace owner references is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same as:
Owner references allow resources and dependents to share the same namespace(s) OR
Owner references allow resources in the same namespace as their dependents

caesarxuchao
caesarxuchao reviewed Feb 7, 2019
View reviewed changes
content/en/docs/concepts/workloads/controllers/garbage-collection.md Outdated
{{< note >}}
Owner references allow resources in the same namespace as the dependents, or
cluster-scoped resources. However, cross-namespace owner references is
disallowed by design.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this more clear:

Cluster-scoped owner may have namespaced dependents or cluster-scoped dependents.
Namespaced owner may only have namespaced dependents in the same namespace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased it to write it from dependents' perspective, because owner refs is written in dependents' metadata, not owners'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@janetkuo janetkuo force-pushed the gc-owner-doc branch 3 times, most recently from 1e30dbd to fc4b8b7 Compare February 7, 2019 23:25
@caesarxuchao
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@Rajakavitha1
Copy link
Contributor

/assign @steveperry-53

Please take a look and state your approval.

@zparnold
Copy link
Member

/approve

1 similar comment
@zhangxiaoyu-zidif
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangxiaoyu-zidif, zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit e063811 into kubernetes:master Feb 13, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@janetkuo
Document owner ref restrictions explicitly (kubernetes#12543)
9e40d03
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@janetkuo
Document owner ref restrictions explicitly (kubernetes#12543)
314d63f
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@janetkuo @yagonobre
Document owner ref restrictions explicitly (kubernetes#12543)
2464719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@caesarxuchao caesarxuchao caesarxuchao left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@liggitt liggitt

@caesarxuchao caesarxuchao

@steveperry-53 steveperry-53

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@janetkuo @liggitt @huyhg @caesarxuchao @Rajakavitha1 @zparnold @zhangxiaoyu-zidif @k8s-ci-robot @kbhawkey @steveperry-53