-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Travis CI dependency #13598
Remove Travis CI dependency #13598
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit de18d61 https://deploy-preview-13598--kubernetes-io-master-staging.netlify.com |
@lucperkins This will need a follow-up PR in k/test-infra. |
What is the advantage of netlify over prow? |
@fejta None, really. There’s just no need for Prow/Travis when all of our CI workloads can be on Netlify rather than split across multiple platforms. We have hundreds of contributors across an expanding range of language communities, and anything we can do to reduce the per-PR cognitive burden of contributing is a small win. |
Running everything on a single system makes sense for sure. Prow is built by the community and the most commonly used CI system, so if you're going to pick a single system for your workloads, all things being equal I would recommend using that over Netlify. |
@fejta Prow was not, however, built to deploy websites and is thus not a subsititute for Netlify, which is the default web publishing platform for the Kubernetes ecosystem |
Prow has a good gitops story. It will trigger arbitrary kubernetes pod workflows in response to git events. These building blocks will compose into a decent CD system. For example, over in test-infra we use prow to github events and:
Similarly, I suspect we can use kubernetes pods to deploy the kubernetes websites. Long-term this would seem an interesting space to explore. |
@fejta Netlify is a fully featured web publishing platform that offers Kubernetes ecosystem projects an enormous feature set, including per-PR deploy previews, cache invalidation, global CDN delivery, support for numerous build tools, file-based redirects, and much more. I think it would be unwise to attempt to recreate this feature set in any system. |
Conclusions? |
@tengqm The original intent behind the PR stands |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Remove Travis CI dependency * Make scripts runnable via chmod * Remove .travis.yml reference in test examples script
* Remove Travis CI dependency * Make scripts runnable via chmod * Remove .travis.yml reference in test examples script
* Remove Travis CI dependency * Make scripts runnable via chmod * Remove .travis.yml reference in test examples script
This PR removes the need for Travis CI in the build pipeline, running everything on Netlify CI instead