Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Travis CI dependency #13598

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Remove Travis CI dependency #13598

merged 3 commits into from
Apr 11, 2019

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Apr 3, 2019

This PR removes the need for Travis CI in the build pipeline, running everything on Netlify CI instead

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 3, 2019
@netlify
Copy link

netlify bot commented Apr 3, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit de18d61

https://deploy-preview-13598--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor

@lucperkins This will need a follow-up PR in k/test-infra.

@lucperkins
Copy link
Contributor Author

@fejta
Copy link

fejta commented Apr 3, 2019

What is the advantage of netlify over prow?

@lucperkins
Copy link
Contributor Author

@fejta None, really. There’s just no need for Prow/Travis when all of our CI workloads can be on Netlify rather than split across multiple platforms. We have hundreds of contributors across an expanding range of language communities, and anything we can do to reduce the per-PR cognitive burden of contributing is a small win.

@fejta
Copy link

fejta commented Apr 3, 2019

Running everything on a single system makes sense for sure.

Prow is built by the community and the most commonly used CI system, so if you're going to pick a single system for your workloads, all things being equal I would recommend using that over Netlify.

@lucperkins
Copy link
Contributor Author

lucperkins commented Apr 3, 2019

@fejta Prow was not, however, built to deploy websites and is thus not a subsititute for Netlify, which is the default web publishing platform for the Kubernetes ecosystem

@fejta
Copy link

fejta commented Apr 3, 2019

Prow has a good gitops story. It will trigger arbitrary kubernetes pod workflows in response to git events. These building blocks will compose into a decent CD system.

For example, over in test-infra we use prow to github events and:

Similarly, I suspect we can use kubernetes pods to deploy the kubernetes websites. Long-term this would seem an interesting space to explore.

@lucperkins
Copy link
Contributor Author

@fejta Netlify is a fully featured web publishing platform that offers Kubernetes ecosystem projects an enormous feature set, including per-PR deploy previews, cache invalidation, global CDN delivery, support for numerous build tools, file-based redirects, and much more. I think it would be unwise to attempt to recreate this feature set in any system.

@tengqm
Copy link
Contributor

tengqm commented Apr 9, 2019

Conclusions?

@lucperkins
Copy link
Contributor Author

@tengqm The original intent behind the PR stands

@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8101de9 into kubernetes:master Apr 11, 2019
@zacharysarah
Copy link
Contributor

P.S. Comedy gold:

Screen Shot 2019-04-11 at 1 36 50 AM

McCoyAle pushed a commit to McCoyAle/website that referenced this pull request Apr 16, 2019
* Remove Travis CI dependency

* Make scripts runnable via chmod

* Remove .travis.yml reference in test examples script
emedina pushed a commit to emedina/website that referenced this pull request Apr 18, 2019
* Remove Travis CI dependency

* Make scripts runnable via chmod

* Remove .travis.yml reference in test examples script
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
* Remove Travis CI dependency

* Make scripts runnable via chmod

* Remove .travis.yml reference in test examples script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants