Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate README in Italian #17518

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Translate README in Italian #17518

merged 3 commits into from
Jan 13, 2020

Conversation

Fale
Copy link
Member

@Fale Fale commented Nov 10, 2019

Add the README file in Italian language

@k8s-ci-robot
Copy link
Contributor

Welcome @Fale!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 10, 2019
@netlify
Copy link

netlify bot commented Nov 10, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cc32911

https://deploy-preview-17518--kubernetes-io-master-staging.netlify.com

@Fale
Copy link
Member Author

Fale commented Dec 11, 2019

/assign @fabriziopandini

@sftim
Copy link
Contributor

sftim commented Dec 11, 2019

/language it
/uncc

(I don't speak Italian!)

@k8s-ci-robot k8s-ci-robot removed the request for review from sftim December 11, 2019 16:36
@k8s-ci-robot k8s-ci-robot added the language/it Issues or PRs related to Italian language label Dec 11, 2019
@sftim
Copy link
Contributor

sftim commented Dec 11, 2019

@Fale do you have someone from the Italian localization team who can give this formal / informal approval?

@Fale
Copy link
Member Author

Fale commented Dec 11, 2019

Hi @sftim, thanks.
Fabrizio told me to assign this ticket to him so that he can do the validation for the language.

@sftim
Copy link
Contributor

sftim commented Dec 11, 2019

I'll also
/cc @fabriziopandini

fabriziopandini
fabriziopandini suggested changes Dec 15, 2019
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fale thanks for this PR! I'm super happy to see the beginning of an Italian localization.

For the future, we should create a document with some localization guidelines, similar to http://kubernetes.io/docs/contribute/style/style-guide/ but specific for the italian.

In the meantime, this is already a great start!
I added some comments, mainly with the goal to make the Italian a little bit more fluent; in some cases, this requires to deviate a little bit from the original wording, but IMO this is acceptable unless the changes are altering the original meaning of the sentences.

README-it.md Outdated Show resolved Hide resolved
README-it.md Outdated Show resolved Hide resolved
README-it.md Outdated Show resolved Hide resolved
README-it.md Outdated Show resolved Hide resolved
README-it.md Outdated Show resolved Hide resolved
README-it.md Outdated Show resolved Hide resolved
README-it.md Outdated Show resolved Hide resolved
README-it.md Outdated Show resolved Hide resolved
README-it.md Outdated Show resolved Hide resolved
README-it.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 16, 2019
@Fale
Copy link
Member Author

Fale commented Dec 16, 2019

Hi @fabriziopandini
thanks a lot for your comments. I think I closed all of them except one which is not clear what is suggestion.
As for the style guide, I do agree that we need to write one so that all translations are homogeneous.

fabriziopandini
fabriziopandini approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fale
Looks great!
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2019
@fabriziopandini
Copy link
Member

/assign @jimangel

@rlenferink
Copy link
Member

Approved by @fabriziopandini as Italian reviewer/approver

/approve
/unassign @jimangel

@rlenferink rlenferink added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: fabriziopandini, rlenferink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: fabriziopandini, rlenferink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d31ec6f into kubernetes:master Jan 13, 2020
@fabriziopandini
Copy link
Member

great work @Fale!
Thanks everyone for the support!

wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@Fale @wawa0210
Translate README in Italian (kubernetes#17518)
3d4b525 
* Translate README in Italian

* integrate comments
@Fale Fale deleted the it branch April 10, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/it Issues or PRs related to Italian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Fale @k8s-ci-robot @sftim @fabriziopandini @rlenferink @jimangel