-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates TOCs to add missing files from #2007 #2149
Conversation
…#2007. Skips the checks for certain inaccessible or deprecated files and removes unused README.md files.
- docs/user-guide/federation/namespaces.md | ||
- docs/user-guide/federation/replicasets.md | ||
- docs/user-guide/federation/secrets.md | ||
- docs/federation/api-reference/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should rename to index.md?
Somehow it doesn't work well with TOC https://deploy-preview-2149--kubernetes-io-master-staging.netlify.com/docs/federation/api-reference/readme/ (because title is missing?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try it. I'm leery of renaming things to "index.md" with whatever weird URL-shortening/prettifying has been installed on the Kubernetes website. I'll give it a test run and see if it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the title isn't missing; there's just both an explicit title and an H1 heading, which looks terrible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, it looks like it works.
## Change Pod Definitions | ||
|
||
Edit both `show-rc.yaml` and `backend-rc.yaml` and replace the | ||
specified `image:` with the one that you built. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an example / tutorial. There are some other files under this folder. Do we want to kill it completely? Should we copy it to become a real example / tutorial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned that in PR #2007. We can punt this and the configmap/README.md to a different PR.
Corrected link on Guides TOC. Corrected duplicate title in federation/api-reference/index.md.
…thub.io into toc-updates
Adds files that failed the new Travis check in PR #2007 that verifies all docs have a TOC entry for titling and findability.
This change is