Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update fr site new value #22210

Merged
merged 2 commits into from
Oct 18, 2020
Merged

update fr site new value #22210

merged 2 commits into from
Oct 18, 2020

Conversation

zhanw15
Copy link
Contributor

@zhanw15 zhanw15 commented Jun 30, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 30, 2020
@zhanw15
Copy link
Contributor Author

zhanw15 commented Jun 30, 2020

/language fr

@k8s-ci-robot k8s-ci-robot added the language/fr Issues or PRs related to French language label Jun 30, 2020
sftim
sftim reviewed Jun 30, 2020
View reviewed changes
i18n/fr.toml Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Jun 30, 2020

Please rebase this pull request against master to bring in a work-around for issue #22222.

@remyleone @sftim
Update i18n/fr.toml
cdc34e6 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@remyleone
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2020
@remyleone
Copy link
Contributor

/assign @kbhawkey

@netlify
Copy link

netlify bot commented Sep 15, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cdc34e6

https://deploy-preview-22210--kubernetes-io-master-staging.netlify.app

@kbhawkey
Copy link
Contributor

Hello @zhanw15 . Thanks for this update.
Are you able to squash your changes to a single commit?
Thank you.

@kbhawkey
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 18, 2020
@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey, remyleone, zhanw15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 018cc1a into kubernetes:master Oct 18, 2020
javidiaz pushed a commit to javidiaz/website that referenced this pull request Oct 19, 2020
@remyleone @sftim @javidiaz
update fr site new value (kubernetes#22210)
15911cc 
* update fr site new value

* Update i18n/fr.toml

Co-authored-by: Tim Bannister <tim@scalefactory.com>

Co-authored-by: Rémy Léone <remy.leone@gmail.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
dashpole pushed a commit to dashpole/website that referenced this pull request Oct 21, 2020
@remyleone @sftim @dashpole
update fr site new value (kubernetes#22210)
2488871 
* update fr site new value

* Update i18n/fr.toml

Co-authored-by: Tim Bannister <tim@scalefactory.com>

Co-authored-by: Rémy Léone <remy.leone@gmail.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@onlydole onlydole Awaiting requested review from onlydole

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@remyleone remyleone

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhanw15 @sftim @remyleone @kbhawkey @k8s-ci-robot