Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix heading text #22327

Merged
merged 1 commit into from
Jul 15, 2020
Merged

fix heading text #22327

merged 1 commit into from
Jul 15, 2020

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jul 4, 2020

issue #22048

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2020
@netlify
Copy link

netlify bot commented Jul 4, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cf1cc32

https://deploy-preview-22327--kubernetes-io-master-staging.netlify.app

@Arhell
Copy link
Member Author

Arhell commented Jul 4, 2020 •
edited
Loading

There are several solutions to this bug.

  1. In the header, remove a little margin-top
  2. To increase the indentation in the document itself
    1

I chose the first option due to the fact that this fixes this bug and the header itself centers a little. Because the navigation is biased down, and this aligns it a little

review page https://deploy-preview-22327--kubernetes-io-master-staging.netlify.app/docs/concepts/overview/components/#kube-apiserver

@Arhell
Copy link
Member Author

Arhell commented Jul 4, 2020

/assign @sftim

@sftim
Copy link
Contributor

sftim commented Jul 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2020
@celestehorgan
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celestehorgan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 58d8236 into kubernetes:master Jul 15, 2020
@Arhell Arhell deleted the fix-text branch July 15, 2020 17:27
@sftim sftim mentioned this pull request Jul 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim Awaiting requested review from sftim

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arhell @sftim @celestehorgan @k8s-ci-robot