Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with k8s.io/docs/concepts/configuration/secret/ #23090

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Fix issue with k8s.io/docs/concepts/configuration/secret/ #23090

merged 1 commit into from
Aug 22, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Aug 12, 2020

Closes #23089

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2020
@netlify
Copy link

netlify bot commented Aug 12, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 05e11bb

https://deploy-preview-23090--kubernetes-io-master-staging.netlify.app

@pjhwa
Copy link
Contributor Author

pjhwa commented Aug 12, 2020

Preview page: https://deploy-preview-23090--kubernetes-io-master-staging.netlify.app/docs/concepts/configuration/secret/

@zacharysarah
Copy link
Contributor

@pjhwa Thanks for the helpful additions!

/lgtm
approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
sftim
sftim reviewed Aug 22, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2020
sftim
sftim reviewed Aug 22, 2020
View reviewed changes
content/en/docs/concepts/configuration/secret.md
@@ -352,6 +352,8 @@ NAME TYPE DATA
db-user-pass-96mffmfh4k Opaque 2 51s
```

You can view a description of the secret:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localizers: if you're checking back on the history of this line, it's OK to use the localized equivalent of “secret”, or the resource name “Secret” - pick whichever seems more appropriate.

@k8s-ci-robot k8s-ci-robot merged commit e258284 into kubernetes:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jimangel jimangel Awaiting requested review from jimangel

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/concepts/configuration/secret/
4 participants
@pjhwa @zacharysarah @k8s-ci-robot @sftim