Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'subscribe' button translate #23230

Merged
merged 1 commit into from
Aug 24, 2020
Merged

'subscribe' button translate #23230

merged 1 commit into from
Aug 24, 2020

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Aug 18, 2020

issue #23224

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2020
@netlify
Copy link

netlify bot commented Aug 18, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5f4456b

https://deploy-preview-23230--kubernetes-io-master-staging.netlify.app

@Arhell
Copy link
Member Author

Arhell commented Aug 18, 2020

review page
https://deploy-preview-23230--kubernetes-io-master-staging.netlify.app/pt/#kubeweekly
/language pt

@k8s-ci-robot k8s-ci-robot added the language/pt Issues or PRs related to Portuguese language label Aug 18, 2020
@Arhell
Copy link
Member Author

Arhell commented Aug 18, 2020

/assign @jhonmike

@jhonmike
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@Arhell
Copy link
Member Author

Arhell commented Aug 24, 2020

/assign @sftim

@sftim
Copy link
Contributor

sftim commented Aug 24, 2020

Sorry, I'm not able to review for the Portuguese localization.
/unassign @sftim

@Arhell
Copy link
Member Author

Arhell commented Aug 24, 2020

@sftim
Hi, I know, lgtm and approve is, you need to merge, thanks

@femrtnz
Copy link
Member

femrtnz commented Aug 24, 2020

/lgtm
/approve

@sftim
Copy link
Contributor

sftim commented Aug 24, 2020

Great, thanks @femrtnz and @jhonmike

Echoing #23230 (comment) and #23230 (comment)
/lgtm
/approve

BTW you can assign kubernetes/sig-docs-leads for approvals, rather than assigning a specific person.

@femrtnz
Copy link
Member

femrtnz commented Aug 24, 2020

Hi @zparnold, could you please have a look?

The Portuguese translation is approved, but we can't approved the PR

/assign @zparnold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: femrtnz, jhonmike, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3cb0307 into kubernetes:master Aug 24, 2020
@Arhell Arhell deleted the btn branch August 24, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonmike jhonmike jhonmike approved these changes

@bradtopol bradtopol Awaiting requested review from bradtopol

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@jhonmike jhonmike

@zparnold zparnold

@femrtnz femrtnz

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pt Issues or PRs related to Portuguese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Arhell @jhonmike @sftim @femrtnz @k8s-ci-robot @zparnold