Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update link in page access-cluster #24070

Merged
merged 2 commits into from
Sep 29, 2020
Merged

update link in page access-cluster #24070

merged 2 commits into from
Sep 29, 2020

Conversation

gaoguangze111
Copy link
Contributor

Update two links in page access-cluster.md. Page updated: https://kubernetes.io/zh/docs/tasks/access-application-cluster/access-cluster/

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2020
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2020
@netlify
Copy link

netlify bot commented Sep 23, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7686c08

https://deploy-preview-24070--kubernetes-io-master-staging.netlify.app

@howieyuen
Copy link
Member

/lgtm
Thanks for the contribution

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2020
@howieyuen
Copy link
Member

/cc @tengqm

@tengqm
Copy link
Contributor

tengqm commented Sep 24, 2020

Can we do a more complete PR?

./scripts/linkchecker.py -l zh -f /docs/tasks/access-application-cluster/access-cluster.md
Language: zh
File: content/zh/docs/tasks/access-application-cluster/access-cluster.md
    /docs/user-guide/kubectl-cheatsheet: Link using redirect records, should use /docs/reference/kubectl/cheatsheet/ instead
    /docs/user-guide/kubectl-overview: Link using redirect records, should use /docs/reference/kubectl/overview/ instead
    /docs/admin/accessing-the-api: Link using redirect records, should use /docs/reference/access-authn-authz/controlling-access/ instead
    /docs/concepts/cluster-administration/authenticate-across-clusters-kubeconfig/: Link using redirect records, should use /docs/tasks/access-application-cluster/configure-access-multiple-clusters/ instead
    /docs/concepts/cluster-administration/authenticate-across-clusters-kubeconfig/: Link using redirect records, should use /docs/tasks/access-application-cluster/configure-access-multiple-clusters/ instead
    /docs/reference/using-api/client-libraries/: Link not using localized page
    /docs/tasks/configure-pod-container/configure-service-account/: Link not using localized page
    /docs/admin/node: Link using redirect records, should use /docs/concepts/architecture/nodes/ instead
    /docs/user-guide/pods: Link using redirect records, should use /docs/concepts/workloads/pods/ instead
    /docs/user-guide/services: Link using redirect records, should use /docs/concepts/services-networking/service/ instead
    /docs/user-guide/services: Link using redirect records, should use /docs/concepts/services-networking/service/ instead
    /docs/concepts/services-networking/service/#ips-and-vips: Link not using localized page

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2020
@gaoguangze111
Copy link
Contributor Author

Updated more links

markthink
markthink reviewed Sep 27, 2020
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 98c496c912a724ecd5c7b55c4e18c04dcdf94117

tanjunchen
tanjunchen reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tanjunchen tanjunchen removed their assignment Sep 28, 2020
@gaoguangze111
Copy link
Contributor Author

/assign @xiangpengzhao

@tengqm
Copy link
Contributor

tengqm commented Sep 29, 2020

A big thank you.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2c7cca1 into kubernetes:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markthink markthink markthink left review comments

@tanjunchen tanjunchen tanjunchen left review comments

@pigletfly pigletfly Awaiting requested review from pigletfly

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@markthink markthink

@tengqm tengqm

@xiangpengzhao xiangpengzhao

@howieyuen howieyuen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gaoguangze111 @howieyuen @tengqm @k8s-ci-robot @markthink @tanjunchen @xiangpengzhao