Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert banner after KubeCon #25173

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Revert banner after KubeCon #25173

merged 1 commit into from
Nov 23, 2020

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Nov 22, 2020

This reverts PR #24714, because KubeCon NA 2020 is over.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2020
@netlify
Copy link

netlify bot commented Nov 22, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0dc8c50

https://deploy-preview-25173--kubernetes-io-master-staging.netlify.app

Arhell
Arhell reviewed Nov 23, 2020
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c5e97343202c3491c08a3ed851276c76252df102

@celestehorgan
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celestehorgan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit f2233db into kubernetes:master Nov 23, 2020
@liggitt liggitt mentioned this pull request Jan 7, 2021
Merged
@sftim sftim deleted the 20201122_revert_banner branch June 9, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@Arhell Arhell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @k8s-ci-robot @celestehorgan @Arhell