Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating cilium network policy docs #29079

Merged
merged 1 commit into from
Sep 1, 2021
Merged

updating cilium network policy docs #29079

merged 1 commit into from
Sep 1, 2021

Conversation

Ritikaa96
Copy link
Contributor

@Ritikaa96 Ritikaa96 commented Jul 22, 2021 •
edited
Loading

The Document : https://kubernetes.io/docs/tasks/administer-cluster/network-policy-provider/cilium-network-policy/
has error link for installing cilium on minikube.
fixed it to stable version: https://docs.cilium.io/en/stable/gettingstarted/k8s-install-default/

However, the details are for cilium v1.8 and can be updated.
/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 22, 2021
@k8s-ci-robot
Copy link
Contributor

@Ritikaa96: The label(s) kind/docs cannot be applied, because the repository doesn't have them.

In response to this:

The Document : https://kubernetes.io/docs/tasks/administer-cluster/network-policy-provider/cilium-network-policy/
has error link for installing cilium on minikube.
fixed it to stable version: https://docs.cilium.io/en/stable/gettingstarted/k8s-install-default/

However, the details are for cilium v1.8 and can be updated.
/kind docs
/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2021
@Ritikaa96
Copy link
Contributor Author

Ritikaa96 commented Jul 22, 2021 •
edited
Loading

/assign @celestehorgan
Hi @celestehorgan PTAL. Also, what do you think about the outdated content? Even for the previous version, the reference link content and content on the docs could have been replaced.

The latest reference link provide installation information of Cilium with other tools too. Maybe we can also generalise it too here and reference to the link only like we have done here.

@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: cee22da

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60f97bbdf43f8e0007ca74a7

😎 Browse the preview: https://deploy-preview-29079--kubernetes-io-main-staging.netlify.app

Arhell
Arhell reviewed Jul 23, 2021
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92ce262370d017639d23f0a7cf536ae73b3d385f

sftim
sftim reviewed Jul 25, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @Ritikaa96

I recommend rewording more of the text, to suggest that this guide assumes you already have a cluster. We could signpost folks towards https://kubernetes.io/docs/tasks/tools/ if they don't have one already.

content/en/docs/tasks/administer-cluster/network-policy-provider/cilium-network-policy.md
@@ -24,7 +24,7 @@ For background on Cilium, read the [Introduction to Cilium](https://docs.cilium.
## Deploying Cilium on Minikube for Basic Testing

To get familiar with Cilium easily you can follow the
[Cilium Kubernetes Getting Started Guide](https://docs.cilium.io/en/stable/gettingstarted/minikube/)
[Cilium Kubernetes Getting Started Guide](https://docs.cilium.io/en/stable/gettingstarted/k8s-install-default/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
[Cilium Kubernetes Getting Started Guide](https://docs.cilium.io/en/stable/gettingstarted/k8s-install-default/)
Cilium [Quick Installation](https://docs.cilium.io/en/stable/gettingstarted/k8s-install-default/) guide

aanm
aanm approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aanm aanm removed their assignment Aug 9, 2021
@Ritikaa96
Copy link
Contributor Author

@celestehorgan PTAL

@celestehorgan
Copy link
Contributor

I'm going to deem @sftim's comment as non-blocking :)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aanm, celestehorgan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit ee84275 into kubernetes:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@Arhell Arhell Arhell left review comments

@aanm aanm aanm approved these changes

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@celestehorgan celestehorgan

@Arhell Arhell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ritikaa96 @k8s-ci-robot @celestehorgan @aanm @sftim @Arhell