Update cloud-controller.md #7316
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 1953bf0 https://deploy-preview-7316--kubernetes-io-master-staging.netlify.com |
|
|
||
| For more information about developing plugins, see | ||
| [Developing Cloud Controller Manager](/docs/tasks/administer-cluster/developing-cloud-controller-manager/). | ||
| For more information about developing plugins, see [Developing Cloud Controller Manager](/docs/tasks/administer-cluster/developing-cloud-controller-manager/). | ||
|
|
||
| ## Authorization |
There was a problem hiding this comment.
This section and its subsections are a bit confusing. The required permissions mentioned in the long description (i.e., the sentences) and the lists don't always match up. I'm new to Kubernetes and don't know which are true.
|
/assign @chenopis |
| @@ -35,7 +35,7 @@ The CCM breaks away some of the functionality of Kubernetes controller manager ( | |||
| * Route controller | |||
| * Service controller | |||
|
|
|||
| In version 1.8, the CCM currently runs the following controllers from the preceding list: | |||
| The CCM currently runs the following controllers from the preceding list: | |||
There was a problem hiding this comment.
Don't say "currently". This is called out in our style guide. The idea is that this topic will still be around a year from now, and the reader won't know what we mean by "current".
There was a problem hiding this comment.
@steveperry-53 Thanks for sharing the style guide, I didn't know it existed! I'll replace "version 1.8" with "version 1.9" and remove the other use of "currently".
There was a problem hiding this comment.
@steveperry-53 fixed.
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenopis, mattayes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
Clean up grammar and fix inconsistencies.
This change is