-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add command line tools reference #8421
Re-add command line tools reference #8421
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit faa7d14 https://deploy-preview-8421--kubernetes-io-master-staging.netlify.com |
/assign @steveperry-53 |
There are some syntax bits sticking out in individual files, but the overall structure and navigation work. |
It looks the tables are rendering as HTML source. |
@zacharysarah, The structure you've set up looks good. I see that you have not put theses inside a @chenopis, Thoughts about not having a |
@bep 👋 Can you shed some light on why the table HTML in For reference, here's how it rendered in v1.10 in Jekyll. |
@zacharysarah hard to tell without actually testing this, but if the file is 90+% HTML, why not create it as a *.html file and jump around this problem. |
@zacharysarah I think all you need is to add |
According to Steve's findings, the files pushed are not the latest version. Please pick the files from another commit (#8283). The contents pushed are not from the release-1.10 branch due to issues in the doc generator. |
@tengqm Thanks for the pointer--I can't cherry-pick the commit, obviously, but I will manually copy the file contents. @steveperry-53 Thanks for the tip! 🎯 |
@tengqm, @steveperry-53 I updated the references files with content from #8283. Can you please verify that this looks good and is ready to go? |
I'm going to go ahead and approve/lgtm this in the interest of getting these files into the docs as soon as possible. @tengqm, If you find any problems, let's address them in a followup PR. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveperry-53 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add CLI tools ref MD files * Add TOC * Add TOC weights * Tweaking table formatting * Update kube-scheduler.md * Updates to kubelet * Use latest version of docs (v1.10) * Update docs to v1.10 * Tweak whitespace * Update docs to v1.10 * Update docs to v1.10 * Update docs to v1.10
This PR re-adds CLI tools reference to mimic the structure in v1.10.