Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to ignore vscode stuffs #8510

Merged
merged 1 commit into from
May 12, 2018
Merged

Update .gitignore to ignore vscode stuffs #8510

merged 1 commit into from
May 12, 2018

Conversation

xlgao-zju
Copy link
Contributor

Update .gitignore to ignore vscode stuffs

Signed-off-by: Xianglin Gao xianglin.gxl@alibaba-inc.com

Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com>
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1d73cf2

https://deploy-preview-8510--kubernetes-io-master-staging.netlify.com

@xlgao-zju
Copy link
Contributor Author

@tengqm
PTAL

@tengqm
Copy link
Contributor

tengqm commented May 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2018
@heckj
Copy link
Contributor

heckj commented May 12, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit f8f20e7 into kubernetes:master May 12, 2018
@xlgao-zju xlgao-zju deleted the update-git-ignore branch May 13, 2018 05:57
mbert pushed a commit to mbert/website that referenced this pull request May 15, 2018
Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants