Remove link that 404's #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Thanks for the PR! I'm going to do a quick rewrite of that paragraph, since minikube (http://kubernetes.io/docs/getting-started-guides/minikube/) is the supported way of locally running Kubernetes going forward. |
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Sep 22, 2022
Followup to kubernetes#990, and also based off of the `alpeb/unversion-common-docs` branch. This is preliminary work to convert `/2` into `/2.9` in a followup PR. For reference, here's the procedure I followed. It was also performed for `2` (s/2.10/2 in the commands below). ```console # Under /features $ find . -type f -exec sed -i -e 's/\/2.10\/features/\.\./g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/tasks/\.\.\/\.\.\/tasks/g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/reference/\.\.\/\.\.\/reference/g' {} \; # Then edit _index.html which refers directly to ../tasks and ../reference # Under /tasks $ find . -type f -exec sed -i -e 's/\/2.10\/tasks/\.\./g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/features/\.\.\/\.\.\/features/g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/reference/\.\.\/\.\.\/reference/g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/getting-started/\.\.\/\.\.\/getting-started/g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/upgrade/\.\.\/\.\.\/upgrade/g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/proxy-injection/\.\.\/\.\.\/proxy-injection/g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/observability/\.\.\/\.\.\/observability/g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/adding-your-service/\.\.\/\.\.\/adding-your-service/g' {} \; # Then edit _index.html which refers directly to ../tasks and ../reference # Under /reference $ find . -maxdepth 1 -type f -exec sed -i -e 's/\/2.10\/reference/\.\./g' {} \; $ find . -maxdepth 1 -type f -exec sed -i -e 's/\/2.10\/features/\.\.\/\.\.\/features/g' {} \; $ find . -maxdepth 1 -type f -exec sed -i -e 's/\/2.10\/tasks/\.\.\/\.\.\/tasks/g' {} \; # Under /reference/cli $ find . -type f -exec sed -i -e 's/\/2.10\/reference/\.\.\/\.\./g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/features/\.\.\/\.\.\/\.\.\/features/g' {} \; $ find . -type f -exec sed -i -e 's/\/2.10\/tasks/\.\.\/\.\.\/\.\.\/tasks/g' {} \; # Under getting-started and overview: just manually edit _index.md ```
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Sep 22, 2022
Followup to kubernetes#991 and also based-off of its branch `alpeb/docs-relative-links`. This completes the docs overhaul. Only thing left to do are the Cloudflare rewrites before we merge this. For reference, here's the procedure I followed: ```console $ git mv linkerd.io/content/2 linkerd.io/content/2.9 $ git mv linkerd.io/static/images/2 linkerd.io/static/images/2.9 $ git mv linkerd.io/layouts/2 linkerd.io/layouts/2.9 ``` Also some more aliases got the hard-coded version removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.