Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: obfuscate secret() calls, resolve sensitive config #5862

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

rangoo94
Copy link
Member

Pull request description

  • Correctly resolve sensitive configuration (i.e. something: 'foo' became "foo" before, instead of unquoted foo)
  • Include sensitive configuration and secret() calls as sensitive words

Example workflow

kind: TestWorkflow
apiVersion: testworkflows.testkube.io/v1
metadata:
  name: example-sensitive
spec:
  config:
    something:
      type: string
      default: blah
      sensitive: true
  steps:
  - shell: echo '{{ secret("example-secret", "example-key") }} {{ config.something }}'

Result Before

seeeensitve-value "blah"

Result After

****ue ****ah

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Changes

Fixes

@rangoo94 rangoo94 requested a review from a team as a code owner September 23, 2024 12:31
@rangoo94 rangoo94 marked this pull request as draft September 23, 2024 12:31
@rangoo94 rangoo94 marked this pull request as ready for review September 23, 2024 13:19
@rangoo94 rangoo94 merged commit 9f29f9f into main Sep 23, 2024
7 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/obfuscate-sensitive-secrets branch September 23, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants