Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't fetch logs for timed out services #5870

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: don't fetch logs for timed out services #5870

merged 1 commit into from
Sep 26, 2024

Conversation

rangoo94
Copy link
Member

Pull request description

  • when the service has timeout: 1s and it fails, "Stop Services" was getting stuck
    • modified to not hang depending on the state

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner September 26, 2024 07:57
@rangoo94 rangoo94 merged commit 9a112a5 into main Sep 26, 2024
20 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/fetching-logs-for-timed-out-services branch September 26, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @vsukhin