Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: determine dynamic status correctly in the execution's expressions #5887

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Oct 1, 2024

Pull request description

  • resolve properly status values, like passed or status
    • earlier, it was not able to resolve it, as undetermined steps were not treat as succeed
    • now, as long as the step is not failed, it's considered passed yet

Example

kind: TestWorkflow
apiVersion: testworkflows.testkube.io/v1
metadata:
  name: example
spec:
  steps:
  - shell: exit 0
  - condition: always
    run:
      shell: |
        echo {{ passed }}

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner October 1, 2024 14:05
@rangoo94 rangoo94 merged commit 6d220ef into main Oct 1, 2024
24 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/current-execution-status branch October 1, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants