sig, retests: Address review comments

Signed-off-by: Brian Carey <bcarey@redhat.com>
kubevirt · Jul 23, 2024 · 05f0c21 · 05f0c21
1 parent 4bb0503
commit 05f0c21
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/pkg/constants/main.go b/pkg/constants/main.go
@@ -32,7 +32,7 @@ const (
 	DefaultMergedPRsRedLevel            = 7.0
 	DefaultMergedPRsNoRetestYellowLevel = 0.75
 	DefaultMergedPRsNoRetestRedLevel    = 0.5
-	DefaultSIGRetestYellowLevel         = 10
+	DefaultSIGRetestYellowLevel         = 1
 	DefaultSIGRetestRedLevel            = 20
 	DefaultBatchStartDate               = "2019-05-06"
 

diff --git a/pkg/output/output.go b/pkg/output/output.go
@@ -186,14 +186,14 @@ func (b *Handler) writeBadge(name, filePath string, data types.RunningAverageDat
 func (b *Handler) writeSIGRetestBadge(name, filePath string, data types.RunningAverageDataItem, levels *Levels) error {
 	var value float64
 
-	switch {
-	case name == constants.SIGComputeRetestBadgeName:
+	switch name {
+	case constants.SIGComputeRetestBadgeName:
 		value = data.SIGComputeRetest
-	case name == constants.SIGNetworkRetestBadgeFileName:
+	case constants.SIGNetworkRetestBadgeFileName:
 		value = data.SIGNetworkRetest
-	case name == constants.SIGStorageRetestBadgeName:
+	case constants.SIGStorageRetestBadgeName:
 		value = data.SIGStorageRetest
-	case name == constants.SIGOperatorRetestBadgeName:
+	case constants.SIGOperatorRetestBadgeName:
 		value = data.SIGOperatorRetest
 	}
 
@@ -206,9 +206,8 @@ func (b *Handler) writeSIGRetestBadge(name, filePath string, data types.RunningA
 	defer f.Close()
 
 	badgeString := fmt.Sprintf("%.0f", value)
-	err = badge.Render(name, badgeString, color, f)
 
-	return err
+	return badge.Render(name, badgeString, color, f)
 }
 
 func (b *Handler) initializeSourcePath() (string, error) {