Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badges: Raise limits for PRs merged with 0 retest #60

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

brianmcarey
Copy link
Member

@brianmcarey brianmcarey commented Jul 11, 2024

What this PR does / why we need it:

The merged PRs with 0 retest has been regularly over 50% of total merged PRs. This currently marks the badge as green.

Lets raise the bar for a green badge to 75% and over. While below 50% will now mark the badge as red.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


The merged PRs with 0 retest has been regularly over 50% of total merged
PRs. This currently marks the badge as green.

Lets raise the bar for a green badge to 75% and over. While below 50%
will now make the badge as red.

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jul 11, 2024
@dhiller
Copy link
Contributor

dhiller commented Jul 11, 2024

The merged PRs with 0 retest has been regularly over 50% of total merged PRs. This currently marks the badge as green.

👍 thanks @brianmcarey !

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@xpivarc
Copy link
Member

xpivarc commented Jul 11, 2024

What a milestone btw 🍾

@brianmcarey
Copy link
Member Author

What a milestone btw 🍾

Yes i thought it was a nice little change to make.

There are a couple of other limits for the rest of the badges that could probably be updated. Will take a look.

@brianmcarey brianmcarey merged commit 7a33eae into main Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants